convert unused doc comments to regular comments#6692
Merged
bors merged 1 commit intorust-lang:masterfrom Feb 22, 2019
Merged
Conversation
|
r? @ehuss (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
SGTM @bors r+ |
Contributor
|
📌 Commit f5723e5 has been approved by |
Contributor
|
⌛ Testing commit f5723e5 with merge 66617c763c1fa83b677fa612fade5a50bf283b83... |
Contributor
|
💡 This pull request was already approved, no need to approve it again.
|
Contributor
|
📌 Commit f5723e5 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Feb 22, 2019
convert unused doc comments to regular comments rust-lang/rust#57882 will cause the unused_doc_comments lint to fire when doc comments are present on macro expansions, where they aren't used. Since cargo uses `#![deny(warnings)]` in tests, the tests fail to build with that change. This PR changes the unused doc comments to be regular comments so the warning isn't triggered. It would be helpful to update cargo in the rust repo after this change, since this blocks the above PR from landing.
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
Contributor
I can post an update shortly. |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Feb 23, 2019
Update cargo 5 commits in b33ce7fc9092962b0657b4c25354984b5e5c47e4..5c6aa46e6f28661270979696e7b4c2f0dff8628f 2019-02-19 18:42:50 +0000 to 2019-02-22 19:32:35 +0000 - convert unused doc comments to regular comments (rust-lang/cargo#6692) - Add more about system library on whether to keep Cargo.lock (rust-lang/cargo#6685) - Warn when excluding non-existing packages (rust-lang/cargo#6679) - Incremental profile cleanup. (rust-lang/cargo#6688) - Various cosmetic improvements (rust-lang/cargo#6687)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#57882 will cause the unused_doc_comments lint to fire when doc comments are present on macro expansions, where they aren't used. Since cargo uses
#![deny(warnings)]in tests, the tests fail to build with that change.This PR changes the unused doc comments to be regular comments so the warning isn't triggered.
It would be helpful to update cargo in the rust repo after this change, since this blocks the above PR from landing.