Cargo test quicker by not building untested examples#6677
Cargo test quicker by not building untested examples#6677dwijnand wants to merge 1 commit intorust-lang:masterfrom
Conversation
|
Test-wise, I tried to adapt tests to the new expectations however, some tests I felt had to be dropped entirely. With the test changes made I felt no further tests were required. But let me know what you think. |
(TIL `cargo test --tests` runs test-enabled examples.)
809f4a4 to
137e23c
Compare
|
I'm not sure I understand the motivation for this. Examples are intentionally built by default in I think it would be reasonable to skip non-tested examples if |
I guess our opinions differ here. I think examples are a great feature built into cargo, but I would've assumed you'd need to run something like Two more questions:
|
I don't know much about how incremental works.
I think that would be the safer route if it is not too complex. |
|
OK, I'll propose that instead. |
(TIL
cargo test --testsruns test-enabled examples.)Pushes forward from #5464
Fixes #6675
r? @ehuss