Upgrade to Rust 2018 & fix edition idioms#6387
Merged
bors merged 5 commits intorust-lang:masterfrom Dec 7, 2018
Merged
Conversation
Contributor
Author
|
Similarly, we could take the time to fix the whole codebase's format and clippy lints. WDYT? |
Contributor
Author
|
Oh yeah this break our Rust 1.28.0 CI setup. Do we care? |
Member
|
Nah seems fine to increase the minimum Rust version. Let's land this then do a rustfmt? |
Contributor
Author
Contributor
Author
|
Not sure if that's not the right syntax, or if bors is waiting for Travis CI validation to pass first, or what. Let's try plain: @bors: r+ |
Contributor
|
💡 This pull request was already approved, no need to approve it again.
|
Contributor
|
📌 Commit cd87368 has been approved by |
Contributor
|
⌛ Testing commit cd87368 with merge 73ed91e689b87d1275124536b85bb7f95cad2cdb... |
Contributor
|
💔 Test failed - status-appveyor |
Contributor
Author
Contributor
bors
added a commit
that referenced
this pull request
Dec 7, 2018
Upgrade to Rust 2018 & fix edition idioms None
Contributor
Author
bors
added a commit
that referenced
this pull request
Dec 7, 2018
Upgrade to Rust 2018 & fix edition idioms None
Contributor
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.