Use "test" profile for cargo build benchmarks.#6309
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
This seems like a good and natural implementation to me, thanks @ehuss! Do others from @rust-lang/cargo feel strongly one way or another here? |
|
I don't know this code well enough to know these simple questions: Is there a way in which this will break existing users? |
I think it is unlikely. Today, using
The only change is that bench targets with
|
|
This LGTM |
|
This sounds like it is definitely an improvement to consistency and explainability!
EDIT: LGTM |
Oh my, I misread what you said. Yes, |
|
@bors: r+ |
|
📌 Commit 739c272 has been approved by |
Use "test" profile for `cargo build` benchmarks. When using `cargo build` (without `--release`), build benchmarks using the "test" profile. This was causing some confusion where the benchmark is placed in the `target/debug` directory, and also causing some duplicates that may not be expected. It also makes it easier to debug benchmarks (previously you had to edit the `[profile.bench]` profile). Closes #5575, closes #6301, closes #4240, closes #4929.
|
☀️ Test successful - status-appveyor, status-travis |
When using
cargo build(without--release), build benchmarks using the "test" profile. This was causing some confusion where the benchmark is placed in thetarget/debugdirectory, and also causing some duplicates that may not be expected. It also makes it easier to debug benchmarks (previously you had to edit the[profile.bench]profile).Closes #5575, closes #6301, closes #4240, closes #4929.