Merged
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Member
|
@bors: delegate=Eh2406 Looks good to me! Although some tests may be failing? |
Contributor
|
✌️ @Eh2406 can now approve this pull request |
Contributor
Author
|
r+ |
Member
|
Ah you'll want @bors: r+ |
Contributor
|
📌 Commit c74aa94 has been approved by |
Contributor
|
📌 Commit c74aa94 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Jul 16, 2018
most sorts can be unstable Inspired by [this](https://github.com/rust-lang/cargo/blob/94f7058a483b05ad742da5efb66dd1c2d4b8619c/src/bin/cargo/main.rs#L112-L122) witch was improved in #5691, I did a quick review of `sort`s in the code. Most can be unstable, some can use a `_key` form, and none had unnecessary allocation.
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by this witch was improved in #5691, I did a quick review of
sorts in the code. Most can be unstable, some can use a_keyform, and none had unnecessary allocation.