Skip to content

Reintroduce the compile progress bar as an unstable feature (-Z compile-progress)#5716

Merged
bors merged 2 commits intorust-lang:masterfrom
kennytm:unstable-compile-progress
Jul 12, 2018
Merged

Reintroduce the compile progress bar as an unstable feature (-Z compile-progress)#5716
bors merged 2 commits intorust-lang:masterfrom
kennytm:unstable-compile-progress

Conversation

@kennytm
Copy link
Member

@kennytm kennytm commented Jul 12, 2018 •
edited
Loading

This allows us to test the feature on-demand to see if there's any other bugs besides #5695.

Also, fixed the flickering #5697 (this was caused by build script emitting Stdout/Stderr events).

kennytm added 2 commits July 12, 2018 11:28
@kennytm kennytm changed the title Reintroduce the compile progress bar as an unstable feature Reintroduce the compile progress bar as an unstable feature (-Z compile-progress) Jul 12, 2018
@alexcrichton
Copy link
Member

alexcrichton commented Jul 12, 2018

@bors: r+

Sounds great to me!

@bors
Copy link
Contributor

bors commented Jul 12, 2018

📌 Commit 9612be6 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jul 12, 2018

⌛ Testing commit 9612be6 with merge a5617df...

bors added a commit that referenced this pull request Jul 12, 2018
@bors
Auto merge of #5716 - kennytm:unstable-compile-progress, r=alexcrichton
a5617df 
Reintroduce the compile progress bar as an unstable feature (-Z compile-progress)

This allows us to test the feature on-demand to see if there's any other bugs besides #5695.

Also, fixed the flickering #5697 (this was caused by build script emitting Stdout/Stderr events).
@bors
Copy link
Contributor

bors commented Jul 12, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing a5617df to master...

@bors bors merged commit 9612be6 into rust-lang:master Jul 12, 2018
@bors bors mentioned this pull request Jul 12, 2018
Merged
@kennytm kennytm deleted the unstable-compile-progress branch July 12, 2018 16:04
@ehuss ehuss mentioned this pull request Jul 12, 2018
Closed
@konstin
Copy link
Contributor

konstin commented Jul 19, 2018

Is there an option to only show the progress bar? This would be really useful for tools which call cargo in a way similar to wasm-pack.

@kennytm
Copy link
Member Author

kennytm commented Jul 19, 2018 •
edited
Loading

Since the progress bar already expects nightly, I suggest an alternative:

  1. Run cargo build -Zunstable-options --build-plan to get a list of jobs to be built.
  2. Run cargo build --message-format json and construct your own tool's progress bar based on stdout (all the human readable progress will be printed to stderr).

(I assume the tool doesn't just run cargo and have its own progress bar implementation)

@konstin
Copy link
Contributor

konstin commented Jul 21, 2018

I already use --message-format json, so I guess I'll go with a custom progress bar then

@mbrubeck mbrubeck mentioned this pull request Aug 7, 2018
Closed
@ehuss ehuss added this to the 1.29.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichton alexcrichton

Labels

None yet

Projects

None yet

Milestone

1.29.0

Development

Successfully merging this pull request may close these issues.

5 participants

@kennytm @alexcrichton @bors @konstin @ehuss