Skip to content

Explain why we need a Vec<Dependency> in Resolve.#5459

Merged
bors merged 1 commit intorust-lang:masterfrom
matklad:more-comments
May 2, 2018
Merged

Explain why we need a Vec<Dependency> in Resolve.#5459
bors merged 1 commit intorust-lang:masterfrom
matklad:more-comments

Conversation

@matklad
Copy link
Contributor

@matklad matklad commented May 2, 2018

Looks like everyone, who sees it, asks the same question, so let's add an explanation!

cc #5428 (comment)

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented May 2, 2018

📌 Commit 20d8ff4 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented May 2, 2018

⌛ Testing commit 20d8ff4 with merge e693a26f6352dcbcadf96174f7344c37a6043dee...

@bors
Copy link
Contributor

bors commented May 2, 2018

💔 Test failed - status-appveyor

@matklad
Copy link
Contributor Author

matklad commented May 2, 2018

@bors retry

@bors
Copy link
Contributor

bors commented May 2, 2018

⌛ Testing commit 20d8ff4 with merge 876d4a86b6e1e84d0e3dfa6b559fb0bd18d29c1e...

@alexcrichton
Copy link
Member

alexcrichton commented May 2, 2018 via email

@bors
Copy link
Contributor

bors commented May 2, 2018

⌛ Testing commit 20d8ff4 with merge 5db0d51...

bors added a commit that referenced this pull request May 2, 2018
Explain why we need a `Vec<Dependency>` in `Resolve`.

Looks like everyone, who sees it, asks the same question, so let's add an explanation!

cc #5428 (comment)
@bors
Copy link
Contributor

bors commented May 2, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 5db0d51 to master...

@bors bors merged commit 20d8ff4 into rust-lang:master May 2, 2018
@matklad matklad deleted the more-comments branch May 2, 2018 20:44
@ehuss ehuss added this to the 1.27.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants