add a rustfmt detail to CONTRIBUTING.md#5343
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 11, 2018
dwijnand:contributing-fmt
Merged
add a rustfmt detail to CONTRIBUTING.md#5343bors merged 1 commit intorust-lang:masterfrom dwijnand:contributing-fmt
bors merged 1 commit intorust-lang:masterfrom
dwijnand:contributing-fmt
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
Nice! Ideally, we should provide an example git hook for this. I’ve written one, but I’ve accidentally deleted the repository with it :( @bors r+ |
Contributor
|
📌 Commit 2f4a40b has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Apr 11, 2018
add a rustfmt detail to CONTRIBUTING.md stealing from the info in #5301 (comment)
Contributor
Author
also ideally rustfmt had a flag to tell it to reformat only changed files (tracked as rust-lang/rustfmt#1324) |
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stealing from the info in #5301 (comment)