Merged
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
@rust-highfive: 🔑 Insufficient privileges: Not in reviewers |
Contributor
|
@rust-highfive: 🔑 Insufficient privileges: not in try users |
Contributor
Author
|
@bors r+ |
Contributor
|
📌 Commit a81bb13 has been approved by |
Contributor
|
⌛ Testing commit a81bb138e16232a4c25557ed6dc2ef1ab8c527eb with merge 2808d886228252c29d1fdda242c6e7781fdfc532... |
Member
|
👍 |
Contributor
Author
|
@bors r- Appveyor failure is legit :sigh: |
Better safe than sorry!
Contributor
Author
|
@bors r+ Turns out, we already have a tests, which sort-of exposes this behavior, by giving clap's error message instead of ours :) Amended this test instead of creating a new one. |
Contributor
|
📌 Commit a1735c7 has been approved by |
Member
|
@bors: p=1 |
Contributor
Author
|
@bors: p=2 |
Contributor
bors
added a commit
that referenced
this pull request
Mar 19, 2018
Regression tests for #5201 Better safe than sorry!
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better safe than sorry!