Copy .pdb files to target directory#5179
Merged
bors merged 2 commits intorust-lang:masterfrom Mar 14, 2018
Merged
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
matklad
commented
Mar 14, 2018
src/cargo/ops/cargo_rustc/context.rs
Outdated
Contributor
Author
There was a problem hiding this comment.
I am not sure this is exactly what we want.
If you crate is a
[lib]
crate-type = [ "cdylib" ]
you might actually be interested in debuginfo as well?
Member
There was a problem hiding this comment.
True yeah, but I think it's fine to always fix that in a follow up (or when it arises)
tests/testsuite/build.rs
Outdated
Member
There was a problem hiding this comment.
I think this may also want a target_env filter
`.pdb` files are for windows debug info (unlike on linux, debug info is in a separate file). Windows executable actually hard-code paths to `.pdb` files, so debugging mvsc rust programs works even without this patch. However, if you want to distribute the executable to other machines, you'd better distribute both `foo.exe` and `foo.pdb`, because absolute paths won't work on another machine. Having same-named .pdb file alongside the binary would work though. closes rust-lang#4960
Member
|
@bors: r+ |
Contributor
|
📌 Commit 9c0d3f2 has been approved by |
Contributor
|
⌛ Testing commit 9c0d3f2 with merge 4b8872f9d70bba93df69fa9ef4da7e520a172838... |
Contributor
|
💔 Test failed - status-appveyor |
Depending on the OS, there might be an additional artifacts for debuginfo (dSYM folder for macs, .pbd file for windows). Given that we can't disable `.pdb` for windows[1], let's just ignore all filenames! [1]: rust-lang/rust#28505)
Member
|
@bors: r+ |
Contributor
|
📌 Commit f930609 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Mar 14, 2018
Copy `.pdb` files to `target` directory `.pdb` files are for windows debug info (unlike on linux, debug info is in a separate file). Windows executable actually hard-code paths to `.pdb` files, so debugging mvsc rust programs works even without this patch. However, if you want to distribute the executable to other machines, you'd better distribute both `foo.exe` and `foo.pdb`, because absolute paths won't work on another machine. Having same-named .pdb file alongside the binary would work though. closes #4960
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Sep 17, 2023
lf-
added a commit
to lf-/cargo
that referenced
this pull request
Sep 19, 2023
EFI also uses the PE format with .pdb files, and rustc generates them, but Cargo does not copy them out of target/*/deps. This is an oversight, so this PR fixes it. Related: rust-osdev/uefi-rs#289 Related: rust-lang#5179
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.pdbfiles are for windows debug info (unlike on linux, debug info isin a separate file). Windows executable actually hard-code paths to
.pdbfiles, so debugging mvsc rust programs works even without thispatch. However, if you want to distribute the executable to other
machines, you'd better distribute both
foo.exeandfoo.pdb, becauseabsolute paths won't work on another machine. Having same-named .pdb
file alongside the binary would work though.
closes #4960