Allow to substitute executed program in ProcessBuilder#4442
Merged
bors merged 1 commit intorust-lang:masterfrom Aug 28, 2017
Merged
Allow to substitute executed program in ProcessBuilder#4442bors merged 1 commit intorust-lang:masterfrom
ProcessBuilder#4442bors merged 1 commit intorust-lang:masterfrom
Conversation
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
Member
|
@bors: r+ |
Contributor
|
📌 Commit d554ce5 has been approved by |
Contributor
|
⌛ Testing commit d554ce5 with merge 2a6b1c11b65a1e456afe97246a4b4791ad6bbe27... |
Contributor
|
💔 Test failed - status-appveyor |
Member
|
@bors: retry |
Contributor
bors
added a commit
that referenced
this pull request
Aug 28, 2017
Allow to substitute executed program in `ProcessBuilder` Extends #4424. Sorry for the noise, turns out it'd also be useful to substite the executed program (e.g. for rls, which needs to use a rustc shim itself) without having to copy over manually all parts of the `ProcessBuilder`. While I'm at it, do you think this needs even more functionality, like being able to specify `None` for the `cwd` or `jobserver` (currently API exposes only ability to specify `Some(...)` as values for those)? r? @alexcrichton
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends #4424. Sorry for the noise, turns out it'd also be useful to substite the executed program (e.g. for rls, which needs to use a rustc shim itself) without having to copy over manually all parts of the
ProcessBuilder.While I'm at it, do you think this needs even more functionality, like being able to specify
Nonefor thecwdorjobserver(currently API exposes only ability to specifySome(...)as values for those)?r? @alexcrichton