Merged
Conversation
It now has an updated initialization routine to hopefully get ssh working on Windows, with a fix for alexcrichton/git2-rs#202
Member
Author
|
@bors: r+ |
Contributor
|
📌 Commit 77b7612 has been approved by |
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
bors
added a commit
that referenced
this pull request
May 8, 2017
Update libssh2-sys It now has an updated initialization routine to hopefully get ssh working on Windows, with a fix for alexcrichton/git2-rs#202
Contributor
|
Is it possible to add a test to cargo that tries to use SSH repos? This is apparently a not-often tested code path that breaks often. |
Member
Author
|
I'd certainly love to add such a test! It'd likely involve spinning up an ssh server, however, which doing so reliably and in a cross-platform manner I'm not sure how to do. |
Contributor
|
Yes, I was afraid of that. Talking to something remote is out of the question? |
Member
Author
|
Unfortunately, yes. |
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It now has an updated initialization routine to hopefully get ssh working on
Windows, with a fix for alexcrichton/git2-rs#202