r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rfcbot fcp merge cargo

Team member @epage has proposed to merge this. The next step is review by the rest of the tagged team members:

• @0xPoe
• @Eh2406
• @Muscraft
• @arlosi
• @ehuss
• @epage
• @joshtriplett
• @weihanglo

Concerns:

• install (feat(config): Stabilize resolver.lockfile-path config #16694 (comment))

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot fcp concern install

Inconsistency in resolver table being applied to cargo install

Should we remove install support or have this inconsistent?

Should we remove install support or have this inconsistent?

In which cases would we need to specify the lockfile path and install binaries? This configuration is primarily for using read-only source directories. I couldn't wrap my head around coming up with a use case for it.

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Should we remove install support or have this inconsistent?

Just remind that we also have an inconsistency of install not respecting [patch] #12855.

Do we think the support of unsetting the lockfile path a blocker? Currently there is no way to do that. And without that, it is hard for people to unset if a global resolver.lockfile-path is applied to cargo-install.

I'm not quite clear which inconsistency we're talking about.

• That cargo install requires --locked to honor resolver.lockfile-path?
• That cargo install with --locked and resolver.lockfile-path doesn't honor other settings in the resolver table?
• Something else?

Also, is there a more detailed description of this feature? Overall I'd like to see a more detailed stabilization report. For example, it seems to reserve {} substitutions, but I don't see that mentioned anywhere. There also seems to be various small details, like it seems to create intermediate directories (which is good). Is the path relative to the workspace root? The current directory? The consideration of an config value versus CLI flag was captured out in #15510 (comment). Things like that would help in understanding what is being proposed here.