fix: apply host.runner only when host-config enabled#16631
Merged
epage merged 2 commits intorust-lang:masterfrom Feb 12, 2026
Merged
fix: apply host.runner only when host-config enabled#16631epage merged 2 commits intorust-lang:masterfrom
host.runner only when host-config enabled#16631epage merged 2 commits intorust-lang:masterfrom
Conversation
Collaborator
|
r? @epage rustbot has assigned @epage. Use Why was this reviewer chosen?The reviewer was selected based on:
|
RalfJung
reviewed
Feb 12, 2026
Member
|
Would be nice to get this into the next nightly to fix Miri. :) |
This is a regression and will be fixed in the next commit
This is a regression found in rust-lang/miri#4855 and introduced by rust-lang#16599 There are other regression that `host.runner` and `host.linker` are accidentally applied to target builds which I plan to fix both in a follow-up PR. (rust-lang#12535 introduced the `host.linker` bug btw)
epage
approved these changes
Feb 12, 2026
rust-bors bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Feb 12, 2026
Update cargo submodule 8 commits in 0c9e687d237ff04b53ccb67b4ce63e9483789e88..ce69df6f72a3b6a2b5c722ba68ddef255344b31c 2026-02-11 05:58:30 +0000 to 2026-02-12 12:39:45 +0000 - fix: apply `host.runner` only when `host-config` enabled (rust-lang/cargo#16631) - fix(cli): Improve bad manifest error (rust-lang/cargo#16630) - fix: Adjust casing of error message (rust-lang/cargo#16625) - Enable triagebot new `[view-all-comments-link]` feature (rust-lang/cargo#16629) - test(help): snapshot cargo help tests (rust-lang/cargo#16626) - Suggest a `workspace.members` entry even from outside the workspace root (rust-lang/cargo#16616) - Reorganize build unit directory layout for new build-dir layout (rust-lang/cargo#16542) - Make the error messaging for `cargo install` aware of `build.build-dir` (rust-lang/cargo#16623)
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Feb 13, 2026
Update cargo submodule 8 commits in 0c9e687d237ff04b53ccb67b4ce63e9483789e88..ce69df6f72a3b6a2b5c722ba68ddef255344b31c 2026-02-11 05:58:30 +0000 to 2026-02-12 12:39:45 +0000 - fix: apply `host.runner` only when `host-config` enabled (rust-lang/cargo#16631) - fix(cli): Improve bad manifest error (rust-lang/cargo#16630) - fix: Adjust casing of error message (rust-lang/cargo#16625) - Enable triagebot new `[view-all-comments-link]` feature (rust-lang/cargo#16629) - test(help): snapshot cargo help tests (rust-lang/cargo#16626) - Suggest a `workspace.members` entry even from outside the workspace root (rust-lang/cargo#16616) - Reorganize build unit directory layout for new build-dir layout (rust-lang/cargo#16542) - Make the error messaging for `cargo install` aware of `build.build-dir` (rust-lang/cargo#16623)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This is a regression found in rust-lang/compiler-builtins#1087
and introduced by #16599
There are other regression that
host.runnerandhost.linkerare accidentally applied to target builds which I plan to fix
both in a follow-up PR.
(#12535 introduced the
host.linkerbug btw)