Convert a few more diagnostics to reports#16065
Closed
jneem wants to merge 2 commits intorust-lang:masterfrom
Closed
Convert a few more diagnostics to reports#16065jneem wants to merge 2 commits intorust-lang:masterfrom
jneem wants to merge 2 commits intorust-lang:masterfrom
Conversation
Collaborator
Contributor
That only works if you only use We are avoiding
|
99c6b81 to
96c8dab
Compare
96c8dab to
7a38ef2
Compare
Contributor
Author
|
Closing in favor of #16066 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 8, 2025
Here I'm continuing to slowly work through multi-part diagnostics and convert them to reports. Like #16035, this converts a warning + note into a single `Group` with a warning title containing note elements. Based on [this comment](#16035 (comment)) I'm not sure if this is actually what you want, mostly because these notes are typically shorter than the ones in #16035. For comparison, I'll open another PR that does multiple groups. Edit: #16065 This is part of #15944
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the version of #16066 that has a group for each message (i.e. a group with a
WARNINGprimary title followed by groups withNOTEsecondary titles).I was a bit surprised to see that (like the single-group version) this has a blank line before the note. Based on this comment I was expecting it not to.
This is part of #15944