Merged
Conversation
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use |
Merged
weihanglo
reviewed
May 24, 2025
src/cargo/core/features.rs
Outdated
| /// would have built this dynamically. | ||
| /// | ||
| /// This does not include `future` since we don't need to create new | ||
| /// projects with it. |
Member
There was a problem hiding this comment.
nit: we use packages 📦 right?
Suggested change
| /// projects with it. | |
| /// packages with it. |
traviscross
reviewed
May 24, 2025
src/cargo/core/features.rs
Outdated
Comment on lines
+539
to
+540
| /// Allows use of editions that are not yet stable. | ||
| (unstable, unstable_edition, "", "reference/unstable.html#unstable-edition"), |
There was a problem hiding this comment.
Suggested change
| /// Allows use of editions that are not yet stable. | |
| (unstable, unstable_edition, "", "reference/unstable.html#unstable-edition"), | |
| /// Allows use of editions that are not yet stable. | |
| (unstable, unstable_editions, "", "reference/unstable.html#unstable-editions"), |
Perhaps it'd be better to name this in the plural. When there is an unstable numbered edition, this will be allowing that as well as the future edition. And generally, at least on the rustc side, we prefer to name feature flags in the plural.
Contributor
Author
There was a problem hiding this comment.
Sure! My thinking was that there is only ever one edition allowed in a manifest, but I'm fine either way.
This adds support for the "future" edition which was added to rustc in rust-lang/rust#137606. To enable support for unstable editions, this introduces a new `unstable-editions` cargo feature. The intent is that instead of having a new feature for each edition that we reuse this feature for all new editions. I don't see a particular reason we should have a separate one for each edition, and this helps a bit with scalability and simplifies some of the edition process. This also includes a change to rework `supports_compat_lint` explained in the comment.
bors
added a commit
to rust-lang/rust
that referenced
this pull request
May 31, 2025
Update cargo 12 commits in 68db37499f2de8acef704c73d9031be6fbcbaee4..64a12460708cf146e16cc61f28aba5dc2463bbb4 2025-05-22 14:27:15 +0000 to 2025-05-30 18:25:08 +0000 - chore: remove HTML comments and inline guide (rust-lang/cargo#15613) - Add .git-blame-ignore-revs (rust-lang/cargo#15612) - refactor: cleanup for `CompileMode` (rust-lang/cargo#15608) - refactor: separate "global" mode from CompileMode (rust-lang/cargo#15601) - fix(doc): pass `toolchain-shared-resources` to get doc styled (rust-lang/cargo#15605) - fix(embedded): Resolve multiple bugs in frontmatter parser (rust-lang/cargo#15573) - chore: Upgrade schemars (rust-lang/cargo#15602) - Update gix & socket2 (rust-lang/cargo#15600) - Add `-Zfix-edition` (rust-lang/cargo#15596) - chore(toml): disable `toml`'s default features, unless necessary (rust-lang/cargo#15598) - docs(README): fix the link to the changelog in the Cargo book (rust-lang/cargo#15597) - Add the future edition (rust-lang/cargo#15595) r? ghost
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
May 31, 2025
Update cargo 12 commits in 68db37499f2de8acef704c73d9031be6fbcbaee4..64a12460708cf146e16cc61f28aba5dc2463bbb4 2025-05-22 14:27:15 +0000 to 2025-05-30 18:25:08 +0000 - chore: remove HTML comments and inline guide (rust-lang/cargo#15613) - Add .git-blame-ignore-revs (rust-lang/cargo#15612) - refactor: cleanup for `CompileMode` (rust-lang/cargo#15608) - refactor: separate "global" mode from CompileMode (rust-lang/cargo#15601) - fix(doc): pass `toolchain-shared-resources` to get doc styled (rust-lang/cargo#15605) - fix(embedded): Resolve multiple bugs in frontmatter parser (rust-lang/cargo#15573) - chore: Upgrade schemars (rust-lang/cargo#15602) - Update gix & socket2 (rust-lang/cargo#15600) - Add `-Zfix-edition` (rust-lang/cargo#15596) - chore(toml): disable `toml`'s default features, unless necessary (rust-lang/cargo#15598) - docs(README): fix the link to the changelog in the Cargo book (rust-lang/cargo#15597) - Add the future edition (rust-lang/cargo#15595) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for the "future" edition which was added to rustc in rust-lang/rust#137606.
To enable support for unstable editions, this introduces a new
unstable-editionscargo feature. The intent is that instead of having a new feature for each edition that we reuse this feature for all new editions. I don't see a particular reason we should have a separate one for each edition, and this helps a bit with scalability and simplifies some of the edition process.This also includes a change to rework
supports_compat_lintexplained in the comment.