refactor(package): split cargo_package to modules#14982
Merged
weihanglo merged 6 commits intorust-lang:masterfrom Dec 25, 2024
Merged
refactor(package): split cargo_package to modules#14982weihanglo merged 6 commits intorust-lang:masterfrom
cargo_package to modules#14982weihanglo merged 6 commits intorust-lang:masterfrom
Conversation
Collaborator
epage
approved these changes
Dec 25, 2024
Contributor
epage
left a comment
There was a problem hiding this comment.
Feel free to merge when the labels are fixed
Contributor
|
As a future refactor, i wonder if the archive creation is enough to be a mod. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 31, 2024
Update cargo 5 commits in c86f4b3a1b153218e6e50861214b0b4b4e695f23..d73d2caf9e41a39daf2a8d6ce60ec80bf354d2a7 2024-12-24 17:49:48 +0000 to 2024-12-31 20:51:21 +0000 - fix(package): warn if symlinks checked out as plain text files (rust-lang/cargo#14994) - test: track caller for `.crate` file publish verification (rust-lang/cargo#14992) - test: relax panic output assertion (rust-lang/cargo#14989) - test: relax `bad_crate_type` to only match error message prefix (rust-lang/cargo#14990) - refactor(package): split `cargo_package` to modules (rust-lang/cargo#14982) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Do nothing but move code around
cargo_package.rs->cargo_package/mod.rscargo_package/vcs.rscargo_package/verify.rsDoing so because I realized how big
cargo_package.rshas grown.Like, the vcs helpers will continue growing with #14981 and potentially other optimizations.
How should we test and review this PR?
All tests pass.