Skip to content

feat: Add custom completer for completing target triple#14535

Merged
bors merged 1 commit intorust-lang:masterfrom
shannmu:_cargo_target_triple
Sep 17, 2024
Merged

feat: Add custom completer for completing target triple#14535
bors merged 1 commit intorust-lang:masterfrom
shannmu:_cargo_target_triple

Conversation

@shannmu
Copy link
Contributor

@shannmu shannmu commented Sep 11, 2024

What does this PR try to resolve?

Tracking issue #14520

Add custom completer for cargo build --target=<TAB>

@rustbot
Copy link
Collaborator

rustbot commented Sep 11, 2024

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-cli Area: Command-line interface, option parsing, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2024
@shannmu
Copy link
Contributor Author

shannmu commented Sep 11, 2024

r? @epage

@rustbot rustbot assigned epage and unassigned ehuss Sep 11, 2024
epage
epage reviewed Sep 11, 2024
View reviewed changes
epage
epage reviewed Sep 11, 2024
View reviewed changes
@shannmu shannmu force-pushed the _cargo_target_triple branch from 35fb89d to 435269b Compare September 15, 2024 18:46
epage
epage reviewed Sep 16, 2024
View reviewed changes
@bors
Copy link
Contributor

bors commented Sep 16, 2024

☔ The latest upstream changes (presumably #14533) made this pull request unmergeable. Please resolve the merge conflicts.

@shannmu shannmu force-pushed the _cargo_target_triple branch from 435269b to 63ef141 Compare September 17, 2024 04:36
@epage
Copy link
Contributor

epage commented Sep 17, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Sep 17, 2024

📌 Commit 63ef141 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2024
@bors
Copy link
Contributor

bors commented Sep 17, 2024

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

  1. git checkout _cargo_target_triple (switch to your branch)
  2. git fetch upstream master (retrieve the latest master)
  3. git rebase upstream/master -p (rebase on top of it)
  4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
  5. git push self _cargo_target_triple --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message 
Auto-merging src/cargo/util/command_prelude.rs
CONFLICT (content): Merge conflict in src/cargo/util/command_prelude.rs
Automatic merge failed; fix conflicts and then commit the result.

@bors bors added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 17, 2024
@shannmu shannmu force-pushed the _cargo_target_triple branch from 63ef141 to 7968f54 Compare September 17, 2024 15:11
@epage
Copy link
Contributor

epage commented Sep 17, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Sep 17, 2024

📌 Commit 7968f54 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. labels Sep 17, 2024
@bors
Copy link
Contributor

bors commented Sep 17, 2024

⌛ Testing commit 7968f54 with merge 10eaf34...

@bors
Copy link
Contributor

bors commented Sep 17, 2024

☀️ Test successful - checks-actions
Approved by: epage
Pushing 10eaf34 to master...

@bors bors merged commit 10eaf34 into rust-lang:master Sep 17, 2024
@bors bors mentioned this pull request Sep 17, 2024
Merged
@bors bors mentioned this pull request Sep 17, 2024
Closed
@epage epage mentioned this pull request Sep 17, 2024
Open
30 tasks
@weihanglo weihanglo mentioned this pull request Sep 20, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 20, 2024
@bors
Auto merge of rust-lang#130632 - weihanglo:update-cargo, r=weihanglo
c0838c8 
Update cargo

16 commits in a9a418d1a22f29e7dfd034e3b93f15657e608a29..eaee77dc1584be45949b75e4c4c9a841605e3a4b
2024-09-15 19:13:12 +0000 to 2024-09-19 21:10:23 +0000
- fix(complete): Harden `--target` completions (rust-lang/cargo#14564)
- Cleanup duplicated check-cfg lint logic (rust-lang/cargo#14567)
- Revert "remove reference to incomplete crates.io feature from docs" (rust-lang/cargo#14562)
- feat: Add custom completer for `cargo help &lt;TAB&gt;` (rust-lang/cargo#14557)
- docs(unstable): Expand on completion documentation (rust-lang/cargo#14563)
- feat: Add custom completer for `cargo build --example=&lt;TAB&gt;` (rust-lang/cargo#14531)
- remove reference to incomplete crates.io feature from docs (rust-lang/cargo#14561)
- fix(complete): Fix problems on my machine (rust-lang/cargo#14558)
- feat: Add custom completer for completing benchmark names (rust-lang/cargo#14532)
- refactor(info): Use the `shell.note` to print the note (rust-lang/cargo#14554)
- feat: Add custom completer for completing test names (rust-lang/cargo#14548)
- Suggest `cargo info` command in the `cargo search` result (rust-lang/cargo#14537)
- feat: Add custom completer for completing target triple (rust-lang/cargo#14535)
- feat: Add custom completer for `cargo -Z &lt;TAB&gt;` (rust-lang/cargo#14536)
- feat: Add custom completer for completing installed binaries (rust-lang/cargo#14534)
- feat: Add custom completer for completing bin names (rust-lang/cargo#14533)

r? ghost
@rustbot rustbot added this to the 1.83.0 milestone Sep 21, 2024
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Sep 21, 2024
@bors
Auto merge of #130632 - weihanglo:update-cargo, r=weihanglo
fab01c1 
Update cargo

16 commits in a9a418d1a22f29e7dfd034e3b93f15657e608a29..eaee77dc1584be45949b75e4c4c9a841605e3a4b
2024-09-15 19:13:12 +0000 to 2024-09-19 21:10:23 +0000
- fix(complete): Harden `--target` completions (rust-lang/cargo#14564)
- Cleanup duplicated check-cfg lint logic (rust-lang/cargo#14567)
- Revert "remove reference to incomplete crates.io feature from docs" (rust-lang/cargo#14562)
- feat: Add custom completer for `cargo help &lt;TAB&gt;` (rust-lang/cargo#14557)
- docs(unstable): Expand on completion documentation (rust-lang/cargo#14563)
- feat: Add custom completer for `cargo build --example=&lt;TAB&gt;` (rust-lang/cargo#14531)
- remove reference to incomplete crates.io feature from docs (rust-lang/cargo#14561)
- fix(complete): Fix problems on my machine (rust-lang/cargo#14558)
- feat: Add custom completer for completing benchmark names (rust-lang/cargo#14532)
- refactor(info): Use the `shell.note` to print the note (rust-lang/cargo#14554)
- feat: Add custom completer for completing test names (rust-lang/cargo#14548)
- Suggest `cargo info` command in the `cargo search` result (rust-lang/cargo#14537)
- feat: Add custom completer for completing target triple (rust-lang/cargo#14535)
- feat: Add custom completer for `cargo -Z &lt;TAB&gt;` (rust-lang/cargo#14536)
- feat: Add custom completer for completing installed binaries (rust-lang/cargo#14534)
- feat: Add custom completer for completing bin names (rust-lang/cargo#14533)

r? ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@epage epage epage left review comments

Assignees

@epage epage

Labels

A-cli Area: Command-line interface, option parsing, etc. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.83.0

Development

Successfully merging this pull request may close these issues.

5 participants

@shannmu @rustbot @bors @epage @ehuss