Skip to content

Fix typo in cargo-bench.md#13903

Closed
michaelkirk wants to merge 1 commit intorust-lang:masterfrom
michaelkirk:patch-1
Closed

Fix typo in cargo-bench.md#13903
michaelkirk wants to merge 1 commit intorust-lang:masterfrom
michaelkirk:patch-1

Conversation

@michaelkirk
Copy link

@michaelkirk michaelkirk commented May 11, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented May 11, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2024
weihanglo
weihanglo reviewed May 13, 2024
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

The build failed. See https://github.com/rust-lang/cargo/actions/runs/9046252088/job/24856873540?pr=13903#step:6:215:

Detected changes of man pages:
 M src/doc/src/commands/cargo-bench.md

Please run `cargo build-man` to rebuild the man pages
and commit the changes.

@weihanglo weihanglo added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 13, 2024
@weihanglo
Copy link
Member

weihanglo commented Jun 13, 2024

I'm going to close due to inactivity. Feel free to reopen if you have a chance to regenerate the man page.

@weihanglo weihanglo closed this Jun 13, 2024
@ehuss ehuss mentioned this pull request Jun 13, 2024
Merged
bors added a commit that referenced this pull request Jun 13, 2024
@bors
Auto merge of #14066 - ehuss:spelling, r=weihanglo
05e61b2 
Fix some documentation misspellings

This is a repost of #13903 with a few other fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weihanglo weihanglo weihanglo left review comments

Assignees

@weihanglo weihanglo

Labels

A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michaelkirk @rustbot @weihanglo