fix: Make lint names snake_case#13635
Merged
bors merged 1 commit intorust-lang:masterfrom Mar 25, 2024
Merged
Conversation
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use |
Contributor
|
This is strange because every lint and group in |
222826f to
0a400d5
Compare
Member
Author
|
I did some more digging and found that:
So I made it so we use |
epage
reviewed
Mar 25, 2024
Comment on lines
+1142
to
+1145
| let normalized_lints = cargo_lints | ||
| .into_iter() | ||
| .map(|(name, lint)| (name.replace('-', "_"), lint)) | ||
| .collect(); |
Contributor
There was a problem hiding this comment.
non-blocking: this could live in toml/mod.rs when we resolve the manifest.
Please don't do that right now as I have probably 20 commits locally changing that code :)
Contributor
|
@bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 26, 2024
…rkingjubilee Update cargo 5 commits in a510712d05c6c98f987af24dd73cdfafee8922e6..499a61ce7a0fc6a72040084862a68b2603e770e8 2024-03-25 03:45:54 +0000 to 2024-03-26 04:17:04 +0000 - fix: do not borrow shell across registry query (rust-lang/cargo#13647) - Do not strip debuginfo by default for MSVC (rust-lang/cargo#13630) - chore(deps): update msrv (rust-lang/cargo#13577) - Fix doc collision for lib/bin with a dash in the inferred name. (rust-lang/cargo#13640) - refactor: Make lint names snake_case (rust-lang/cargo#13635) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on #13621, I somehow missed that lint names should be
snake_caseaccording to therustc-dev-guideas well asRFC #344.This PR renames:
implicit-features=>implicit_featiresrust-2024-compatibility=>rust_2024_compatibility.Note: We should probably have some tooling to enforce this, but I was unsure if it belonged to this PR or another one. One solution would be to use a macro to create the
const LINT_NAME: Lint = {...}, whereLINT_NAMEwould be theidentas well as thename: &'static strand then have a method onLintto make it lowercase as needed. This is whatrustcdoes, and it could work well here. It would ensure snake case asconstnames need to beSCREAMING_SNAKE_CASE, or a warning is shown.