Go back to using curl to download snapshots#1347
Conversation
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
src/etc/dl-snapshot.py
Outdated
…ot.py" This reverts commit aceba88. Conflicts: src/etc/dl-snapshot.py
4fc34c4 to
8c0525c
Compare
|
@bors r+ 8c05 |
|
⌛ Testing commit 8c0525c with merge caa5b60... |
|
💔 Test failed - cargo-win-64 |
|
@bors: retry force |
|
⚡ Previous build results are reusable. Rebuilding only cargo-win-64... |
|
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-32, cargo-win-64 |
|
This change back to curl has broken the downloading of snapshots for me on Windows using Msys2. |
|
Hm, do you have |
|
I just manually edited the scripts to pass the -k option to curl. The problem is that with msys2, the msys2 curl works fine, but the mingw64 curl is broken, and to build cargo you need cmake and cmake depends on the mingw64 curl. You could also install an external cmake so you don't need the mingw64 curl installed. |
|
Thanks for the info, @retep998 ! |
We've had too many problems using urllib to make it worth it.
Closes #1346
Closes #1088
cc #1319 (using a proxy through curl)