crates-io: Set Content-Type: application/json only for requests with a body payload#13264
Merged
bors merged 2 commits intorust-lang:masterfrom Jan 9, 2024
Merged
crates-io: Set Content-Type: application/json only for requests with a body payload#13264bors merged 2 commits intorust-lang:masterfrom
Content-Type: application/json only for requests with a body payload#13264bors merged 2 commits intorust-lang:masterfrom
Conversation
Collaborator
|
r? @ehuss (rustbot has picked a reviewer for you, use r? to override) |
weihanglo
approved these changes
Jan 8, 2024
Member
weihanglo
left a comment
There was a problem hiding this comment.
Could you bump a patch version for crates-io package?
I am okay with this change and would be surprised if it breaks other registries, though seems like the RFC doesn't say anything about whether an empty body can have a Content-Type header.
…h a body payload
b5232e6 to
1049aa1
Compare
Member
Author
since it could be seen as a breaking change I opted for a minor version bump. let me know if that's okay with you or if you want me to change it :) |
weihanglo
approved these changes
Jan 9, 2024
Member
|
It is not a SemVer breaking change, though I am fine with merging it as-is. Thank you :) @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 10, 2024
Update cargo 14 commits in 2ce45605d9db521b5fd6c1211ce8de6055fdb24e..3e428a38a34e820a461d2cc082e726d3bda71bcb 2024-01-04 18:04:13 +0000 to 2024-01-09 20:46:36 +0000 - refactor: replace `iter_join` with `itertools::join` (rust-lang/cargo#13275) - docs(unstable): doc comments for items and fields (rust-lang/cargo#13274) - crates-io: Set `Content-Type: application/json` only for requests with a body payload (rust-lang/cargo#13264) - fix: only inherit workspace package table if the new package is a member (rust-lang/cargo#13261) - feat(cli): add colors to `-Zhelp` console output (rust-lang/cargo#13269) - chore(deps): update msrv (rust-lang/cargo#13266) - refactor(toml): Make it more obvious to update package-dependent fields (rust-lang/cargo#13267) - chore(ci): Fix MSRV:3 updates (rust-lang/cargo#13268) - chore(ci): Shot-in-the-dark fix for MSRV updating (rust-lang/cargo#13265) - fix: set OUT_DIR for all units with build scripts (rust-lang/cargo#13204) - fix(manifest): Provide unused key warnings for lints table (rust-lang/cargo#13262) - test(manifest): Verify we warn on unused workspace.package fields (rust-lang/cargo#13263) - docs(changelog): Call out cargo-new lockfile change (rust-lang/cargo#13260) - chore: Add dependency dashboard (rust-lang/cargo#13255) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
The
Content-Typerequest header is only supposed to be used if the request comes with a body payload.cargois currently sending it unconditionally, even forGETrequests that typically don't have a payload attached to them.This PR changes the implementation to only attach the header if the request has a body payload.