doc: clarify caret requirements#12679
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 16, 2023
tompscanlan:caret-doc
Merged
doc: clarify caret requirements#12679bors merged 1 commit intorust-lang:masterfrom tompscanlan:caret-doc
bors merged 1 commit intorust-lang:masterfrom
tompscanlan:caret-doc
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @epage (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
weihanglo
approved these changes
Sep 16, 2023
Member
weihanglo
left a comment
There was a problem hiding this comment.
This looks way better than I expected! Is this ready to merge?
Contributor
Author
|
Thanks. I was expecting some discussion. Go for it if it looks good.
…On Sat, Sep 16, 2023, 4:45 AM Weihang Lo ***@***.***> wrote:
***@***.**** approved this pull request.
This looks way better than I expected! Is this ready to merge?
—
Reply to this email directly, view it on GitHub
<#12679 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2AEUIWHTZWQGWR5KQCBFTX2VRKPANCNFSM6AAAAAA42OB25U>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
Thanks! You've done a great job so I don't have to change any word :) @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 18, 2023
Update cargo 6 commits in d5336f813df39d476e61fc46daabb1446350660a..b4ddf95ad9954118ac0dae835f2966394ad04c02 2023-09-14 19:55:49 +0000 to 2023-09-18 03:48:09 +0000 - doc: differentiate defaults for split-debuginfo (rust-lang/cargo#12680) - feat(cli): Add '-n' to dry-run (rust-lang/cargo#12660) - feat: stabilize credential-process and registry-auth (rust-lang/cargo#12649) - refactor: use `RegistryOrIndex` enum to replace two booleans (rust-lang/cargo#12677) - doc: clarify caret requirements (rust-lang/cargo#12679) - feat(pkgid): Allow incomplete versions when unambigious (rust-lang/cargo#12614) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
clearing up caret version requirements
possibly fixes #12112
How should we test and review this PR?
expert review...