Prerelease candidates error message#12659
Merged
bors merged 4 commits intorust-lang:masterfrom Sep 14, 2023
Merged
Conversation
Collaborator
|
r? @epage (rustbot has picked a reviewer for you, use r? to override) |
epage
reviewed
Sep 12, 2023
epage
reviewed
Sep 12, 2023
epage
reviewed
Sep 12, 2023
Comment on lines
2695
to
2699
| required by package `foo v0.1.0 [..]` | ||
| if you are looking for the prerelease package it needs to be specified explicitly | ||
| prerelease-deps = { version = "0.1.1-pre1" } | ||
| perhaps a crate was updated and forgotten to be re-vendored?"#, |
Contributor
There was a problem hiding this comment.
nit: Should we indent the suggested version req both for "quoting" it and for setting it apart from the suggestion that may come after it?
Contributor
Author
|
I'm gonna go ahead and edit history. @loloicci, I am sorry if this removes the attribution on your work. |
6642373 to
e8f3e02
Compare
e8f3e02 to
50f1455
Compare
Contributor
Author
|
Edited history so that the test was in a separate commit, and so that all tests pass on every commit. This allows you to track the incremental progress on the error messages. |
epage
approved these changes
Sep 12, 2023
Contributor
Author
|
@epage you approved but did not tell bors, what did you intend to convey by that response? |
Contributor
|
Sorry, thought I said to r= when ready @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 15, 2023
Update cargo 11 commits in 2fc85d15a542bfb610aff7682073412cf635352f..d5336f813df39d476e61fc46daabb1446350660a 2023-09-09 01:49:46 +0000 to 2023-09-14 19:55:49 +0000 - fix: emit a warning for `credential-alias` shadowing (rust-lang/cargo#12671) - refactor: fix lint errors in preparation of `[lints]` table integration (rust-lang/cargo#12669) - Limit cargo add feature print (rust-lang/cargo#12662) - Clippy (rust-lang/cargo#12667) - Prerelease candidates error message (rust-lang/cargo#12659) - Fix typos: `informations` -> `information` (rust-lang/cargo#12666) - chore: update globset to 0.4.13 (rust-lang/cargo#12665) - refactor: Consolidate clap/shell styles (rust-lang/cargo#12655) - libgit2 fixed upstream (rust-lang/cargo#12657) - Index summary enum (rust-lang/cargo#12643) - feat(help): Add styling to help output (rust-lang/cargo#12578) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Error messages reporting on versions that do not match the request incorrectly ignore pre-release versions. This is because the version requirement
"*"cannot match prerelease versions. #12315How should we test and review this PR?
Sorry for the large amount of white space changes, fmt got to fmt. 🤷♂️
The process was:
"*"toAnyAdditional information
The old "did you mean to specify a pre-release" #7191 check only occurred when version requirement does not match any versions and you depended on a package that did not have any non-prerelease versions. Making it rarely useful.
The new one will appear any time your version requirement does not match any versions and the package does have pre-release versions. Which may be too common.
I'm open to suggestions for better heuristic.
It's also not clear that the new message make sense in the case of patched versions.