fix(lints): Doctest extraction should respect [lints]#12501
Merged
bors merged 2 commits intorust-lang:masterfrom Aug 14, 2023
Merged
fix(lints): Doctest extraction should respect [lints]#12501bors merged 2 commits intorust-lang:masterfrom
[lints]#12501bors merged 2 commits intorust-lang:masterfrom
Conversation
Collaborator
|
r? @weihanglo (rustbot has picked a reviewer for you, use r? to override) |
weihanglo
approved these changes
Aug 14, 2023
Member
weihanglo
left a comment
There was a problem hiding this comment.
doctests always looks exotic as it constructs all rustflags in ops module.
Anyway, thank you all!
Member
|
@bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 14, 2023
Update cargo 6 commits in 7e9de3f4ec3708f500bec142317895b96131e47c..7c3904d6c3ed54e8a413023519b55a536ad44d5b 2023-08-13 00:47:32 +0000 to 2023-08-14 20:11:43 +0000 - fix(lints): Doctest extraction should respect `[lints]` (rust-lang/cargo#12501) - test: relax assertions of panic message (again) (rust-lang/cargo#12500) - doc(unstable): `cargo test` does not provide `--keep-going` (rust-lang/cargo#12492) - fix(log): enable ansi color only in terminal (rust-lang/cargo#12488) - Update cargo-yank.md (rust-lang/cargo#12490) - test: bypass `rustc --test` impl details for `-Zfuture-incompat-test` (rust-lang/cargo#12491) r? `@ghost`
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Apr 7, 2024
Update cargo 6 commits in 7e9de3f4ec3708f500bec142317895b96131e47c..7c3904d6c3ed54e8a413023519b55a536ad44d5b 2023-08-13 00:47:32 +0000 to 2023-08-14 20:11:43 +0000 - fix(lints): Doctest extraction should respect `[lints]` (rust-lang/cargo#12501) - test: relax assertions of panic message (again) (rust-lang/cargo#12500) - doc(unstable): `cargo test` does not provide `--keep-going` (rust-lang/cargo#12492) - fix(log): enable ansi color only in terminal (rust-lang/cargo#12488) - Update cargo-yank.md (rust-lang/cargo#12490) - test: bypass `rustc --test` impl details for `-Zfuture-incompat-test` (rust-lang/cargo#12491) r? `@ghost`
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
Update cargo 6 commits in 7e9de3f4ec3708f500bec142317895b96131e47c..7c3904d6c3ed54e8a413023519b55a536ad44d5b 2023-08-13 00:47:32 +0000 to 2023-08-14 20:11:43 +0000 - fix(lints): Doctest extraction should respect `[lints]` (rust-lang/cargo#12501) - test: relax assertions of panic message (again) (rust-lang/cargo#12500) - doc(unstable): `cargo test` does not provide `--keep-going` (rust-lang/cargo#12492) - fix(log): enable ansi color only in terminal (rust-lang/cargo#12488) - Update cargo-yank.md (rust-lang/cargo#12490) - test: bypass `rustc --test` impl details for `-Zfuture-incompat-test` (rust-lang/cargo#12491) r? `@ghost`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note the first commit shows the bug and the second commit fixes it
Fixes #12497