Replace invalid panic_unwind std feature with panic-unwind#12364
Merged
bors merged 1 commit intorust-lang:masterfrom Jul 16, 2023
AlexTMjugador:patch-1
Merged
Replace invalid panic_unwind std feature with panic-unwind#12364bors merged 1 commit intorust-lang:masterfrom AlexTMjugador:patch-1
panic_unwind std feature with panic-unwind#12364bors merged 1 commit intorust-lang:masterfrom
AlexTMjugador:patch-1
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @epage (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Contributor
|
Thanks, this was changed via rust-lang/rust#108865. @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 18, 2023
Update cargo 11 commits in 694a579566a9a1482b20aff8a68f0e4edd99bd28..1b15556767f4b78a64e868eedf4073c423f02b93 2023-07-11 22:28:29 +0000 to 2023-07-18 14:44:47 +0000 - Fix "cargo doc --open" crash on WSL2 (rust-lang/cargo#12373) - fix(git): respect scp-like URL for nested submodules (rust-lang/cargo#12359) - Upgrade to indexmap v2 (rust-lang/cargo#12368) - refactor: Clean up package metadata (rust-lang/cargo#12352) - Correct unspecifiead to unspecified (rust-lang/cargo#12363) - Replace invalid `panic_unwind` std feature with `panic-unwind` (rust-lang/cargo#12364) - Bump to 0.74.0; update changelog (rust-lang/cargo#12361) - Bump version of crates-io due to unintentional semver-breaking change (rust-lang/cargo#12357) - chore: Automatically update dependencies monthly (rust-lang/cargo#12341) - docs: Use heading attributes to control the fragment. (rust-lang/cargo#12339) - Rustfmt with latest nightly. (rust-lang/cargo#12351) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
The documentation for the unstable
build-std-featuresflag mentions that a default-enabled feature forstdispanic_unwind. However, as of 2023-07-16, that feature does not even exist in the latest nightlies:The
stdCargo.tomldoes not contain thepanic_unwindfeature either, but it defines apanic-unwindfeature, which works as intended with thebuild-std-featuresflag.Therefore, let's update the documentation to refer to the intended feature instead, which improves its accuracy and reduces developer time waste.
How should we test and review this PR?
Run e.g.
cargo build --release -Z build-std -Z build-std-features=panic-unwind --target x86_64-unknown-linux-gnuinstead ofcargo build --release -Z build-std -Z build-std-features=panic_unwind --target x86_64-unknown-linux-gnu, and watch how the first one works as intended but the second one just shows an error.