doc: intra-doc links and doc comments for build script#12133
Merged
bors merged 1 commit intorust-lang:masterfrom May 13, 2023
Merged
doc: intra-doc links and doc comments for build script#12133bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @epage (rustbot has picked a reviewer for you, use r? to override) |
5ffb807 to
762531d
Compare
epage
approved these changes
May 13, 2023
Contributor
epage
left a comment
There was a problem hiding this comment.
Feel free to merge on my behalf whether you end up fixing it or not
| @@ -1,3 +1,36 @@ | |||
| //! A module about how to execute a custom build script and parse its output. | |||
Contributor
There was a problem hiding this comment.
Side note: If custom_build.rs is really about build scripts, should we make that more obvious, whether thats renaming this to build_script.rs or build_rs.rs?
Member
Author
There was a problem hiding this comment.
Had the same thought. I could see custom build/build script/build.rs co-exist everywhere. build_script.rs gets my vote and I can send a PR fixing all occurrences then.
762531d to
227b2e5
Compare
Member
Author
|
@bors r=epage |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 17, 2023
Update cargo 8 commits in 13413c64ff88dd6c2824e9eb9374fc5f10895d28..09276c703a473ab33daaeb94917232e80eefd628 2023-05-10 13:46:18 +0000 to 2023-05-16 21:43:35 +0000 - docs: Clarify that crates.io doesn't link to docs.rs right away. (rust-lang/cargo#12146) - docs(ref): Clarify MSRV is generally minor (rust-lang/cargo#12122) - Fix `check_for_file_and_add`'s check for conflict file (rust-lang/cargo#12135) - Fixes: Incorrect document link (rust-lang/cargo#12143) - doc: intra-doc links and doc comments for build script (rust-lang/cargo#12133) - Add Cargo team charter. (rust-lang/cargo#12010) - Remove useless drop of copy type (rust-lang/cargo#12136) - Fix dep/feat syntax with hidden implicit optional dependencies (rust-lang/cargo#12130) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
More docs and intra-doc links for
src/cargo/core/compiler/custom_build.rsHow should we test and review this PR?
Then proofread it!