docs(registry): Further specify owner-remove response (#12056)#12068
Merged
bors merged 1 commit intorust-lang:masterfrom May 2, 2023
Bhardwaj-Himanshu:#12056
Merged
docs(registry): Further specify owner-remove response (#12056)#12068bors merged 1 commit intorust-lang:masterfrom Bhardwaj-Himanshu:#12056
bors merged 1 commit intorust-lang:masterfrom
Bhardwaj-Himanshu:#12056
Conversation
Contributor
|
Since this documents the reality of how both canonical sides behave (crates.io, cargo), going ahead with this. @bors r+ |
Contributor
Contributor
bors
added a commit
that referenced
this pull request
May 1, 2023
docs(registry): Further specify owner-remove response (#12056) ### What does this PR try to resolve? This fixes a documentation issue as mentioned in #12056. ### How should we test and review this PR? This is just a markdown file change, so it does not break anything. ### Additional information Let me know if you have any changes or suggestions or how to write the tests for markdown files as well! Thanks
ehuss
reviewed
May 1, 2023
Contributor
|
@bors r- There are some issues with this PR. |
Contributor
|
💔 Test failed - checks-actions |
Contributor
|
We should probably move the current comment above the ˋ"ok": trueˋ line and add one above the msg field to warn that it is unused. Changes to use it can follow later. @Bhardwaj-Himanshu |
Contributor
Author
|
Thanks @2ndDerivative, added some more changes as recommended! Let me know your thoughts about it or any more changes needed! |
weihanglo
reviewed
May 2, 2023
Member
weihanglo
left a comment
There was a problem hiding this comment.
Could you also squash commits? We don't really want to keep those intermediate commits in git history.
weihanglo
approved these changes
May 2, 2023
Member
|
Thanks! @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 3, 2023
Update cargo 16 commits in 9e586fbd8b931494067144623b76c37d213b1ab6..ac84010322a31f4a581dafe26258aa4ac8dea9cd 2023-04-25 22:09:11 +0000 to 2023-05-02 13:41:16 +0000 - docs(registry): Further specify owner-remove response (rust-lang/cargo#12056) (rust-lang/cargo#12068) - Remove repeated definite articles (rust-lang/cargo#12067) - Document that adding `#[non_exhaustive]` on existing items is breaking. (rust-lang/cargo#10877) - docs(commands): add missed preposition (rust-lang/cargo#12073) - Fix warning with unused mut (rust-lang/cargo#12065) - chore: move build-man workflow away from shell (rust-lang/cargo#12048) - feat: Add `-Zmsrv-policy` feature flag (rust-lang/cargo#12043) - chore: new xtask to check stale paths in autolabel defintions (rust-lang/cargo#12051) - cargo-tree: Handle -e no-proc-macro when building the graph (rust-lang/cargo#12044) - chore: update trigger_files in autolabel (rust-lang/cargo#12052) - fix broken markdown in docs (rust-lang/cargo#12049) - home: fix & enhance documentation (rust-lang/cargo#12047) - chore: Mark unpublished crates as such (rust-lang/cargo#12045) - Include rust-version in publish request (rust-lang/cargo#12041) - chore(xtask): Add `cargo xtask unpublished` (rust-lang/cargo#12039) - docs(ref): Specify 'rust_version' in Index format (rust-lang/cargo#12040) r? `@ghost`
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
May 3, 2023
Update cargo 16 commits in 9e586fbd8b931494067144623b76c37d213b1ab6..ac84010322a31f4a581dafe26258aa4ac8dea9cd 2023-04-25 22:09:11 +0000 to 2023-05-02 13:41:16 +0000 - docs(registry): Further specify owner-remove response (rust-lang/cargo#12056) (rust-lang/cargo#12068) - Remove repeated definite articles (rust-lang/cargo#12067) - Document that adding `#[non_exhaustive]` on existing items is breaking. (rust-lang/cargo#10877) - docs(commands): add missed preposition (rust-lang/cargo#12073) - Fix warning with unused mut (rust-lang/cargo#12065) - chore: move build-man workflow away from shell (rust-lang/cargo#12048) - feat: Add `-Zmsrv-policy` feature flag (rust-lang/cargo#12043) - chore: new xtask to check stale paths in autolabel defintions (rust-lang/cargo#12051) - cargo-tree: Handle -e no-proc-macro when building the graph (rust-lang/cargo#12044) - chore: update trigger_files in autolabel (rust-lang/cargo#12052) - fix broken markdown in docs (rust-lang/cargo#12049) - home: fix & enhance documentation (rust-lang/cargo#12047) - chore: Mark unpublished crates as such (rust-lang/cargo#12045) - Include rust-version in publish request (rust-lang/cargo#12041) - chore(xtask): Add `cargo xtask unpublished` (rust-lang/cargo#12039) - docs(ref): Specify 'rust_version' in Index format (rust-lang/cargo#12040) r? `@ghost`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This fixes a documentation issue as mentioned in #12056.
How should we test and review this PR?
This is just a markdown file change, so it does not break anything.
Additional information
Let me know if you have any changes or suggestions or how to write the tests for markdown files as well!
Thanks