Merged
Conversation
Collaborator
|
r? @epage (rustbot has picked a reviewer for you, use r? to override) |
weihanglo
reviewed
Apr 28, 2023
Member
weihanglo
left a comment
There was a problem hiding this comment.
Thanks for this.
Could you also fix failing doctests for other crates in this PR? I can see at least cargo-test-support is failing as well.
2cda053 to
30f4b17
Compare
30f4b17 to
ea0d487
Compare
Contributor
Author
|
Thank you very much for your guidance. I modified the documentation test case in Other crates did not find errors. |
Registry::new_handle doc-test failed
weihanglo
reviewed
May 4, 2023
Member
weihanglo
left a comment
There was a problem hiding this comment.
Thanks! Only some bits of tiny issues left.
df7b432 to
ff7ff7d
Compare
weihanglo
approved these changes
May 4, 2023
Member
|
Thanks! @bors r+ |
Contributor
Contributor
bors
added a commit
that referenced
this pull request
May 4, 2023
fix: doc-test failures ### What does this PR try to resolve? When I read the source code, I found that the `Registry::new_handle` document test failed and seemed to be missing parameters; There is no change in this [PR](https://github.com/rust-lang/cargo/pull/10592/files#diff-12973056cf99e8de997011a8738a6740a7dfd06142a73f122f3b35218db37351).
Contributor
|
💥 Test timed out |
Contributor
|
@bors retry macos stable builder is running extremely slow. |
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 5, 2023
Update cargo 10 commits in ac84010322a31f4a581dafe26258aa4ac8dea9cd..569b648b5831ae8a515e90c80843a5287c3304ef 2023-05-02 13:41:16 +0000 to 2023-05-05 15:49:44 +0000 - xtask-unpublished: output a markdown table (rust-lang/cargo#12085) - fix: hack around `libsysroot` instead of `libtest` (rust-lang/cargo#12088) - Optimize usage under rustup. (rust-lang/cargo#11917) - Update lock to normalize `home` dep (rust-lang/cargo#12084) - fix: doc-test failures (rust-lang/cargo#12055) - feat(cargo-metadata): add `workspace_default_members` (rust-lang/cargo#11978) - doc: clarify implications of `cargo-yank` (rust-lang/cargo#11862) - chore: Use `[workspace.dependencies]` (rust-lang/cargo#12057) - support for shallow clones and fetches with `gitoxide` (rust-lang/cargo#11840) - Build by PackageIdSpec, not name, to avoid ambiguity (rust-lang/cargo#12015) r? `@ghost`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
When I read the source code, I found that the
Registry::new_handledocument test failed and seemed to be missing parameters;There is no change in this PR.