Remove the deprecated build command infrastructure#1195
Merged
bors merged 2 commits intorust-lang:masterfrom Jan 20, 2015
Merged
Remove the deprecated build command infrastructure#1195bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
This aspect of the manifest has been deprecated for quite some time now, and this commit purges the support entirely.
Whenever a build script or a plugin depends on a native dynamic library, the dylib search path will be required to include the path to the generated dynamic library. Currently Cargo does not augment the search path, causing load errors or execution errors whenever builds are attempted in this case. This commit remedies the situation by ensuring that dynamic libraries show up in dylib search paths. This commit is necessary to fully migrate the remaining tests from the old build command infrastructure to build scripts.
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Contributor
|
⌛ Testing commit 50e00c9 with merge e30748b... |
Contributor
|
💔 Test failed - cargo-win-32 |
Member
Author
|
@bors: retry |
bors
added a commit
that referenced
this pull request
Jan 20, 2015
Along the way this also fixes a few bugs with build scripts with respect to dynamic native libraries which are linked into build scripts themselves.
Contributor
Contributor
|
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-32, cargo-win-64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Along the way this also fixes a few bugs with build scripts with respect to dynamic native libraries which are linked into build scripts themselves.