Bump crates-io to 0.36.0 by weihanglo · Pull Request #11820 · rust-lang/cargo

weihanglo · 2023-03-09T17:04:55Z

This was an overlook of #11600

Since we already got #11806 to backport, I guess it is not harmful to beta-nominated Nominated to backport to the beta branch. this as well. Maybe it do need a backport as src/cargo/ops/registry.rs use a new public API from that PR.

BTW, please help check if it is really a breaking change.

rustbot · 2023-03-09T17:05:00Z

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

This was an overlook of rust-lang#11600

epage · 2023-03-09T18:06:29Z

@bors r+

bors · 2023-03-09T18:06:31Z

📌 Commit 8296cfe has been approved by epage

It is now in the queue for this repository.

ehuss · 2023-03-09T18:56:56Z

@bors r-

This doesn't look like a semver breaking change. It is only adding a new function, unless I am missing something.

ehuss · 2023-03-09T18:58:53Z

As for a beta backport, I think that will be required for cargo-the-library to not break.

weihanglo · 2023-03-09T19:24:01Z

This doesn't look like a semver breaking change. It is only adding a new function, unless I am missing something.

In terms of API change, it is no doubt SemVer-compatible. I wonder whether behaviour change is a SemVer breakage. The Registry::req() function now rejects invalid tokens.

ehuss · 2023-03-09T19:41:44Z

I see. I normally wouldn't be too concerned about that since per our discussion on the original change, the likelihood of this being a problem is close to zero.

However, since I don't think there are really any significant users of crates-io besides cargo itself, then I don't think it hurts too much to burn through version numbers.

@bors r+

bors · 2023-03-09T19:41:46Z

📌 Commit 8296cfe has been approved by ehuss

It is now in the queue for this repository.

bors · 2023-03-09T19:50:32Z

⌛ Testing commit 8296cfe with merge 7c6601b...

Bump crates-io to 0.36.0 This was an overlook of #11600 Since we already got #11806 to backport, I guess it is not harmful to <https://github.com/rust-lang/cargo/labels/beta-nominated> this as well. Maybe it do need a backport as `src/cargo/ops/registry.rs` use a new public API from that PR. BTW, please help check if it is really a breaking change.

bors · 2023-03-09T20:10:10Z

💔 Test failed - checks-actions

ehuss · 2023-03-09T20:18:58Z

@bors retry

#11821

bors · 2023-03-09T20:19:07Z

⌛ Testing commit 8296cfe with merge 0dec9a3...

bors · 2023-03-09T21:19:50Z

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 0dec9a3 to master...

bors · 2023-03-09T21:19:50Z

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 0dec9a3 to master...

bors · 2023-03-09T21:19:54Z

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

Bump crates-io to 0.36.0 This was an overlook of rust-lang#11600 Since we already got rust-lang#11806 to backport, I guess it is not harmful to <https://github.com/rust-lang/cargo/labels/beta-nominated> this as well. Maybe it do need a backport as `src/cargo/ops/registry.rs` use a new public API from that PR. BTW, please help check if it is really a breaking change.

[beta-1.69] backport #11820 Beta backports: - #11820 In order to make CI pass, the following PRs are also cherry-picked: - #11817

14 commits in 7d3033d2e59383fd76193daf9423c3d141972a7d..4a3c588b1f0a8e2dc8dd8789dbf3b6a71b02ed49 2023-03-08 17:05:08 +0000 to 2023-03-14 14:05:36 +0000 - ci: make clean-test-output a script for reuse (rust-lang/cargo#11848) - Accurately show status when downgrading dependencies (rust-lang/cargo#11839) - docs(contrib): Move Design Principles earlier in the book (rust-lang/cargo#11842) - docs(contrib): Point compilation docs to doc comments (rust-lang/cargo#11841) - `cargo install --git` multiple packages with binaries found hint (rust-lang/cargo#11835) - Disable flaky auth tests when `gitoxide` runs them (rust-lang/cargo#11830) - Add some documentation on writing cross-compilation tests (rust-lang/cargo#11825) - chore: Use sparse protocol on stable CI (rust-lang/cargo#11829) - Notice for potential unexpected shell expansions in help text of `cargo-add` (rust-lang/cargo#11826) - Add tracking issue to gitoxide unstable docs (rust-lang/cargo#11822) - Bump crates-io to 0.36.0 (rust-lang/cargo#11820) - Bump to 0.71.0; update changelog (rust-lang/cargo#11815) - docs(contrib): Move overview to lib (rust-lang/cargo#11809) - Fix semver check for 1.68 (rust-lang/cargo#11817)

Update cargo 14 commits in 7d3033d2e59383fd76193daf9423c3d141972a7d..4a3c588b1f0a8e2dc8dd8789dbf3b6a71b02ed49 2023-03-08 17:05:08 +0000 to 2023-03-14 14:05:36 +0000 - ci: make clean-test-output a script for reuse (rust-lang/cargo#11848) - Accurately show status when downgrading dependencies (rust-lang/cargo#11839) - docs(contrib): Move Design Principles earlier in the book (rust-lang/cargo#11842) - docs(contrib): Point compilation docs to doc comments (rust-lang/cargo#11841) - `cargo install --git` multiple packages with binaries found hint (rust-lang/cargo#11835) - Disable flaky auth tests when `gitoxide` runs them (rust-lang/cargo#11830) - Add some documentation on writing cross-compilation tests (rust-lang/cargo#11825) - chore: Use sparse protocol on stable CI (rust-lang/cargo#11829) - Notice for potential unexpected shell expansions in help text of `cargo-add` (rust-lang/cargo#11826) - Add tracking issue to gitoxide unstable docs (rust-lang/cargo#11822) - Bump crates-io to 0.36.0 (rust-lang/cargo#11820) - Bump to 0.71.0; update changelog (rust-lang/cargo#11815) - docs(contrib): Move overview to lib (rust-lang/cargo#11809) - Fix semver check for 1.68 (rust-lang/cargo#11817) r? `@ghost`

…nglo [beta-1.69] cargo beta backports 3 commits in 9880b408a3af50c08fab3dbf4aa2a972df71e951..7b18c85808a6b45ec8364bf730617b6f13e0f9f8 2023-02-28 19:39:39 +0000 to 2023-03-17 12:29:33 +0000 - [beta-1.69] backport rust-lang/cargo#11824 (rust-lang/cargo#11863) - [beta-1.69] backport rust-lang/cargo#11820 (rust-lang/cargo#11823) - chore: Backport rust-lang/cargo#11630 to `1.69.0` (rust-lang/cargo#11806) r? `@ghost`

rustbot assigned ehuss Mar 9, 2023

rustbot added A-interacts-with-crates.io Area: interaction with registries S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2023

Bump crates-io to 0.36.0

8296cfe

This was an overlook of rust-lang#11600

weihanglo force-pushed the bump-crates-io branch from 6321ebb to 8296cfe Compare March 9, 2023 17:10

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2023

bors added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 9, 2023

weihanglo added the beta-nominated Nominated to backport to the beta branch. label Mar 9, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. labels Mar 9, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 9, 2023

ehuss mentioned this pull request Mar 9, 2023

gitoxide auth tests sporadically failing #11821

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2023

bors merged commit 0dec9a3 into rust-lang:master Mar 9, 2023

weihanglo mentioned this pull request Mar 9, 2023

[beta-1.69] backport #11820 #11823

Merged

bors added a commit that referenced this pull request Mar 10, 2023

Auto merge of #11823 - weihanglo:rust-1.69.0, r=ehuss

4a4d795

[beta-1.69] backport #11820 Beta backports: - #11820 In order to make CI pass, the following PRs are also cherry-picked: - #11817

weihanglo deleted the bump-crates-io branch March 10, 2023 13:04

weihanglo mentioned this pull request Mar 14, 2023

Update cargo rust-lang/rust#109150

Merged

weihanglo mentioned this pull request Mar 17, 2023

[beta-1.69] cargo beta backports rust-lang/rust#109265

Merged

ehuss added this to the 1.70.0 milestone Mar 26, 2023

weihanglo mentioned this pull request Jan 9, 2024

crates-io: Set Content-Type: application/json only for requests with a body payload #13264

Merged

Conversation

weihanglo commented Mar 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Mar 9, 2023

Uh oh!

epage commented Mar 9, 2023

Uh oh!

bors commented Mar 9, 2023

Uh oh!

ehuss commented Mar 9, 2023

Uh oh!

ehuss commented Mar 9, 2023

Uh oh!

weihanglo commented Mar 9, 2023

Uh oh!

ehuss commented Mar 9, 2023

Uh oh!

bors commented Mar 9, 2023

Uh oh!

bors commented Mar 9, 2023

Uh oh!

bors commented Mar 9, 2023

Uh oh!

ehuss commented Mar 9, 2023

Uh oh!

bors commented Mar 9, 2023

Uh oh!

bors commented Mar 9, 2023

Uh oh!

bors commented Mar 9, 2023

Uh oh!

bors commented Mar 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

weihanglo commented Mar 9, 2023 •

edited

Loading