Skip to content

chore: Make dependencies alphabetical order#11719

Merged
bors merged 1 commit intorust-lang:masterfrom
Muscraft:order-toml-deps
Feb 15, 2023
Merged

chore: Make dependencies alphabetical order#11719
bors merged 1 commit intorust-lang:masterfrom
Muscraft:order-toml-deps

Conversation

@Muscraft
Copy link
Member

@Muscraft Muscraft commented Feb 15, 2023

[dependencies] in some Cargo.toml were out of alphabetical order. This made it slightly more time-consuming to find if a dependency was in a Cargo.toml.

This PR makes it so that they are in alphabetical order.

Note: rustc-workspace-hack was left alone at the bottom as it is a special dependency.

@rustbot
Copy link
Collaborator

rustbot commented Feb 15, 2023

r? @weihanglo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-dependency-resolution Area: dependency resolution and the resolver A-interacts-with-crates.io Area: interaction with registries A-testing-cargo-itself Area: cargo's tests S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2023
weihanglo
weihanglo approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Do we have any automation either in CI or local to check this?

@epage
Copy link
Contributor

epage commented Feb 15, 2023

I'm always split on whether to sort for easier discovery or to organize around related domains/needs. Granted, when the dependencies table gets large enough, the latter becomes difficult.

Looks good to me. Do we have any automation either in CI or local to check this?

cargo add will at least help in preserving the sorting going forward (when people use it)

rust-lang/rustfmt#4091 would be the ideal way to ensure sorting

@weihanglo
Copy link
Member

weihanglo commented Feb 15, 2023

Going to merge but still seek automation to help with this.

@bors r+

@bors
Copy link
Contributor

bors commented Feb 15, 2023

📌 Commit c3043d9 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2023
@bors
Copy link
Contributor

bors commented Feb 15, 2023

⌛ Testing commit c3043d9 with merge 25b8771...

@Muscraft
Copy link
Member Author

Muscraft commented Feb 15, 2023

Looks good to me. Do we have any automation either in CI or local to check this?

I still need to write automation for this. In the long term, I want to develop a set of tools for cargo that can deal with all sorts of things. It is a work in progress

@bors
Copy link
Contributor

bors commented Feb 15, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 25b8771 to master...

@bors bors merged commit 25b8771 into rust-lang:master Feb 15, 2023
@Muscraft Muscraft deleted the order-toml-deps branch February 15, 2023 17:34
@bors bors mentioned this pull request Feb 15, 2023
Closed
@weihanglo weihanglo mentioned this pull request Feb 17, 2023
Merged
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this pull request Feb 18, 2023
@weihanglo
Update cargo
55a7915 
10 commits in 39c13e67a5962466cc7253d41bc1099bbcb224c3..17b3d0de0897e1c6b8ca347bd39f850bb0a5b9f6
2023-02-12 02:01:08 +0000 to 2023-02-17 19:45:09 +0000

- fix: unsupported protocol error on old macos version (rust-lang/cargo#11733)
- Error on invalid alphanumeric token for crates.io (rust-lang/cargo#11600)
- Add clippy lints (rust-lang/cargo#11722)
- chore: Make dependencies alphabetical order (rust-lang/cargo#11719)
- chore: bump mdbook to 0.4.27 (rust-lang/cargo#11716)
- Amend `mdman` tests. (rust-lang/cargo#11715)
- Run CI for macOS on nightly (rust-lang/cargo#11712)
- doc: doc comments and intra-doc links for `core::compiler` (rust-lang/cargo#11711)
- Ensure em dashes are recognizable in markup (rust-lang/cargo#11646)
- Set CARGO_BIN_NAME environment variable also for binary examples (rust-lang/cargo#11705)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 18, 2023
@matthiaskrgr
Rollup merge of rust-lang#108197 - weihanglo:update-cargo, r=weihanglo
5d5e0b0 
Update cargo

10 commits in 39c13e67a5962466cc7253d41bc1099bbcb224c3..17b3d0de0897e1c6b8ca347bd39f850bb0a5b9f6 2023-02-12 02:01:08 +0000 to 2023-02-17 19:45:09 +0000

- fix: unsupported protocol error on old macos version (rust-lang/cargo#11733)
- Error on invalid alphanumeric token for crates.io (rust-lang/cargo#11600)
- Add clippy lints (rust-lang/cargo#11722)
- chore: Make dependencies alphabetical order (rust-lang/cargo#11719)
- chore: bump mdbook to 0.4.27 (rust-lang/cargo#11716)
- Amend `mdman` tests. (rust-lang/cargo#11715)
- Run CI for macOS on nightly (rust-lang/cargo#11712)
- doc: doc comments and intra-doc links for `core::compiler` (rust-lang/cargo#11711)
- Ensure em dashes are recognizable in markup (rust-lang/cargo#11646)
- Set CARGO_BIN_NAME environment variable also for binary examples (rust-lang/cargo#11705)

r? `@ghost`
@ehuss ehuss added this to the 1.69.0 milestone Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@weihanglo weihanglo

Labels

A-dependency-resolution Area: dependency resolution and the resolver A-interacts-with-crates.io Area: interaction with registries A-testing-cargo-itself Area: cargo's tests S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.69.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Muscraft @rustbot @epage @weihanglo @bors @ehuss