Cargo by default saves credentials to .cargo/credentials.toml#11533
Merged
bors merged 2 commits intorust-lang:masterfrom Jan 4, 2023
Merged
Cargo by default saves credentials to .cargo/credentials.toml#11533bors merged 2 commits intorust-lang:masterfrom
.cargo/credentials.toml#11533bors merged 2 commits intorust-lang:masterfrom
Conversation
Collaborator
|
r? @ehuss (rustbot has picked a reviewer for you, use r? to override) |
.cargo/credential.toml.cargo/credentials.toml
0xPoe
approved these changes
Jan 4, 2023
Member
0xPoe
left a comment
There was a problem hiding this comment.
Code changes look good to me. Thanks!
But I found in our Unstable Features docs, we still use the credentials file. Do you know if we need to update it?
Member
Author
|
Fixed. Thank you for the review! |
Contributor
|
Thanks! @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 14, 2023
8 commits in d992ab4e9034930e7809749f04077045af8f4d79..1cd6d3803dfb0b342272862a8590f5dfc9f72573 2023-01-10 14:36:41 +0100 to 2023-01-12 18:40:36 +0000 - Fix for rust-lang/cargo#11555 (rust-lang/cargo#11568) - chore: Fix typos (rust-lang/cargo#11561) - fix(docs): fix typo learm => learn in cargo tree docs (rust-lang/cargo#11560) - Add fix for CVE-2022-46176 (rust-lang/cargo#11556) - Fix panic on target dependency errors. (rust-lang/cargo#11541) - Fix some doc links (rust-lang/cargo#11538) - Cargo by default saves credentials to `.cargo/credentials.toml` (rust-lang/cargo#11533) - Fix a typo in the registries documentation. (rust-lang/cargo#11535)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 14, 2023
Update cargo 8 commits in d992ab4e9034930e7809749f04077045af8f4d79..1cd6d3803dfb0b342272862a8590f5dfc9f72573 2023-01-10 14:36:41 +0100 to 2023-01-12 18:40:36 +0000 - Fix for rust-lang/cargo#11555 (rust-lang/cargo#11568) - chore: Fix typos (rust-lang/cargo#11561) - fix(docs): fix typo learm => learn in cargo tree docs (rust-lang/cargo#11560) - Add fix for CVE-2022-46176 (rust-lang/cargo#11556) - Fix panic on target dependency errors. (rust-lang/cargo#11541) - Fix some doc links (rust-lang/cargo#11538) - Cargo by default saves credentials to `.cargo/credentials.toml` (rust-lang/cargo#11533) - Fix a typo in the registries documentation. (rust-lang/cargo#11535)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Cargo team discussed this in the triage meeting and agree that it has been long enough to write to
.cargo/credentials.tomlby default.Fixes #11509.
cc rust-lang/crates.io#5730 rust-lang/crates.io#5732
How should we test and review this PR?
Integration tests included.
Additional information
We also talked about theoretically dropping the support of the old
credentialsfor any new features. That might “force” people to migrate, though doing that has low benefits.