Improve the error message if publish is false or empty list#11280
Merged
bors merged 3 commits intorust-lang:masterfrom Oct 24, 2022
Merged
Improve the error message if publish is false or empty list#11280bors merged 3 commits intorust-lang:masterfrom
publish is false or empty list#11280bors merged 3 commits intorust-lang:masterfrom
Conversation
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
|
r? @epage (rust-highfive has picked a reviewer for you, use r? to override) |
f6e6f9f to
f5a5871
Compare
Member
Author
I think we can use |
weihanglo
approved these changes
Oct 24, 2022
Member
weihanglo
left a comment
There was a problem hiding this comment.
I think we can use
VecStringOrBoolforpublic, but I am not sure does it make sense to use it in the Manifest struct.
We can discuss it afterward. The pull request looks good to me to be merged.
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
f5a5871 to
66a8488
Compare
weihanglo
reviewed
Oct 24, 2022
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Member
|
Thanks! @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
compiler-errors
pushed a commit
to compiler-errors/rust
that referenced
this pull request
Oct 26, 2022
5 commits in 071eeaf210708219a5a1b2c4728ca2f97df7f2ae..9210810d1fd7b51ae0439a0a363cc50e36963455 2022-10-22 01:17:55 +0000 to 2022-10-25 22:31:50 +0000 - Fix 410 gone response handling (rust-lang/cargo#11286) - Fix inequality in "stale mtime" log messages (rust-lang/cargo#11281) - doc(cargo-tree): mention it considering feature unification (rust-lang/cargo#11282) - Improve the error message if `publish` is `false` or empty list (rust-lang/cargo#11280) - Add test for deleted index entry (rust-lang/cargo#11278)
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Oct 26, 2022
Update cargo 5 commits in 071eeaf210708219a5a1b2c4728ca2f97df7f2ae..9210810d1fd7b51ae0439a0a363cc50e36963455 2022-10-22 01:17:55 +0000 to 2022-10-25 22:31:50 +0000 - Fix 410 gone response handling (rust-lang/cargo#11286) - Fix inequality in "stale mtime" log messages (rust-lang/cargo#11281) - doc(cargo-tree): mention it considering feature unification (rust-lang/cargo#11282) - Improve the error message if `publish` is `false` or empty list (rust-lang/cargo#11280) - Add test for deleted index entry (rust-lang/cargo#11278)
JohnTitor
pushed a commit
to JohnTitor/rust
that referenced
this pull request
Oct 26, 2022
Update cargo 5 commits in 071eeaf210708219a5a1b2c4728ca2f97df7f2ae..9210810d1fd7b51ae0439a0a363cc50e36963455 2022-10-22 01:17:55 +0000 to 2022-10-25 22:31:50 +0000 - Fix 410 gone response handling (rust-lang/cargo#11286) - Fix inequality in "stale mtime" log messages (rust-lang/cargo#11281) - doc(cargo-tree): mention it considering feature unification (rust-lang/cargo#11282) - Improve the error message if `publish` is `false` or empty list (rust-lang/cargo#11280) - Add test for deleted index entry (rust-lang/cargo#11278)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
close #11262
Improve the error message if
publishis the false or empty list.Say
publishis set tofalseor an empty list in Cargo.toml and prevents publishing.How should we test and review this PR?
Unit test
Additional information
If there was a way we could tell
publishto be empty orfalse, I think it would get better. If you know an easy way to implement it, please feel free to comment.