Remove the prepended newline in cargo vendor config output#11271
Closed
sionik wants to merge 1 commit intorust-lang:masterfrom
sionik:feature/vendor-rm-newline
Closed
Remove the prepended newline in cargo vendor config output#11271sionik wants to merge 1 commit intorust-lang:masterfrom sionik:feature/vendor-rm-newline
cargo vendor config output#11271sionik wants to merge 1 commit intorust-lang:masterfrom
sionik:feature/vendor-rm-newline
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) soon. Please see the contribution instructions for more information. |
Signed-off-by: Simon Richter <simon@sinic.eu>
Member
|
Thanks for your contribution. I wonder if we should fix this in upstream. @epage, it seems to be a behaviour from toml_edit. Is that newline expected? |
epage
added a commit
to epage/toml_edit
that referenced
this pull request
Oct 21, 2022
epage
added a commit
to epage/toml_edit
that referenced
this pull request
Oct 21, 2022
Contributor
I've posted a PR with the fix: toml-rs/toml#362 |
epage
added a commit
to epage/cargo
that referenced
this pull request
Oct 21, 2022
This supersedes rust-lang#11271
Contributor
|
Closing in favor of #11273 |
bors
added a commit
that referenced
this pull request
Oct 22, 2022
fix: Remove leading newline in vendor output This supersedes #11271
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo vendorprints all progress tostderr.After it finished the vendoring it prints the necessary configuration to
stdout.The
stdoutoutput starts with a newline which will be removed by this PR.Tested with
cargo vendor | tee vendor_config.