feat(publish): Support 'publish.timeout' config behind '-Zpublish-timeout' by epage · Pull Request #11230 · rust-lang/cargo

epage · 2022-10-13T14:33:08Z

Originally, crates.io would block on publish requests until the publish
was complete, giving cargo publish this behavior by extension. When
crates.io switched to asynchronous publishing, this intermittently broke
people's workflows when publishing multiple crates. I say interittent
because it usually works until it doesn't and it is unclear why to the
end user because it will be published by the time they check. In the
end, callers tend to either put in timeouts (and pray), poll the
server's API, or use crates-index crate to poll the index.

This isn't sufficient because

For any new interested party, this is a pit of failure they'll fall
into
crates-index has re-implemented index support incorrectly in the past,
currently doesn't handle auth, doesn't support git-cli, etc.
None of these previous options work if we were to implement
workspace-publish support (cargo publish multiple packages at once #1169)
The new sparse registry might increase the publish times, making the
delay easier to hit manually
The new sparse registry goes through CDNs so checking the server's API
might not be sufficient
Once the sparse registry is available, crates-index users will find
out when the package is ready in git but it might not be ready through
the sparse registry because of CDNs

This introduces unstable support for blocking by setting
publish.timeout to non-zero value.

A step towards #9507

…eout' Originally, crates.io would block on publish requests until the publish was complete, giving `cargo publish` this behavior by extension. When crates.io switched to asynchronous publishing, this intermittently broke people's workflows when publishing multiple crates. I say interittent because it usually works until it doesn't and it is unclear why to the end user because it will be published by the time they check. In the end, callers tend to either put in timeouts (and pray), poll the server's API, or use `crates-index` crate to poll the index. This isn't sufficient because - For any new interested party, this is a pit of failure they'll fall into - crates-index has re-implemented index support incorrectly in the past, currently doesn't handle auth, doesn't support `git-cli`, etc. - None of these previous options work if we were to implement workspace-publish support (rust-lang#1169) - The new sparse registry might increase the publish times, making the delay easier to hit manually - The new sparse registry goes through CDNs so checking the server's API might not be sufficient - Once the sparse registry is available, crates-index users will find out when the package is ready in git but it might not be ready through the sparse registry because of CDNs This introduces unstable support for blocking by setting `publish.timeout` to non-zero value. A step towards rust-lang#9507

rust-highfive · 2022-10-13T14:33:12Z

r? @weihanglo

(rust-highfive has picked a reviewer for you, use r? to override)

weihanglo

Looks good to me.

This can be seen as #11062 but disabled the blocking by default, so no behaviour change unless user opts in intentionally.

I think it is good to go. We can always revert it if some issue occurs.

weihanglo · 2022-10-13T15:39:17Z

@bors r+

bors · 2022-10-13T15:39:19Z

📌 Commit 04d836f has been approved by weihanglo

It is now in the queue for this repository.

bors · 2022-10-13T16:21:12Z

⌛ Testing commit 04d836f with merge b592ba4...

bors · 2022-10-13T17:22:28Z

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing b592ba4 to master...

12 commits in b8f30cb23c4e5f20854a4f683325782b7cff9837..b332991a57c9d055f1864de1eed93e2178d49440 2022-10-10 19:16:06 +0000 to 2022-10-13 22:05:28 +0000 - Differentiate the warning when an alias (built-in or user-defined) shadows an external subcommand (rust-lang/cargo#11170) - chore: Update tests for latest clap (rust-lang/cargo#11235) - feat(publish): Support 'publish.timeout' config behind '-Zpublish-timeout' (rust-lang/cargo#11230) - Add missing edition (rust-lang/cargo#11231) - doc(profiles): add module level doc (rust-lang/cargo#11219) - refactor(publish): Clarify which SourceId is being used (rust-lang/cargo#11216) - Add new SourceKind::SparseRegistry to differentiate sparse registries (rust-lang/cargo#11209) - Fix deadlock when build scripts are waiting for input on stdin (rust-lang/cargo#11205) - refactor: New variant `FeaturesFor::ArtifactDep` (rust-lang/cargo#11184) - Fix rustdoc warning about unclosed HTML tag (rust-lang/cargo#11221) - refactor(tests): Prepare for wait-for-publish test changes (rust-lang/cargo#11210) - Add configuration option for controlling crates.io protocol (rust-lang/cargo#11215)

Update cargo 12 commits in b8f30cb23c4e5f20854a4f683325782b7cff9837..b332991a57c9d055f1864de1eed93e2178d49440 2022-10-10 19:16:06 +0000 to 2022-10-13 22:05:28 +0000 - Differentiate the warning when an alias (built-in or user-defined) shadows an external subcommand (rust-lang/cargo#11170) - chore: Update tests for latest clap (rust-lang/cargo#11235) - feat(publish): Support 'publish.timeout' config behind '-Zpublish-timeout' (rust-lang/cargo#11230) - Add missing edition (rust-lang/cargo#11231) - doc(profiles): add module level doc (rust-lang/cargo#11219) - refactor(publish): Clarify which SourceId is being used (rust-lang/cargo#11216) - Add new SourceKind::SparseRegistry to differentiate sparse registries (rust-lang/cargo#11209) - Fix deadlock when build scripts are waiting for input on stdin (rust-lang/cargo#11205) - refactor: New variant `FeaturesFor::ArtifactDep` (rust-lang/cargo#11184) - Fix rustdoc warning about unclosed HTML tag (rust-lang/cargo#11221) - refactor(tests): Prepare for wait-for-publish test changes (rust-lang/cargo#11210) - Add configuration option for controlling crates.io protocol (rust-lang/cargo#11215)

12 commits in b8f30cb23c4e5f20854a4f683325782b7cff9837..b332991a57c9d055f1864de1eed93e2178d49440 2022-10-10 19:16:06 +0000 to 2022-10-13 22:05:28 +0000 - Differentiate the warning when an alias (built-in or user-defined) shadows an external subcommand (rust-lang/cargo#11170) - chore: Update tests for latest clap (rust-lang/cargo#11235) - feat(publish): Support 'publish.timeout' config behind '-Zpublish-timeout' (rust-lang/cargo#11230) - Add missing edition (rust-lang/cargo#11231) - doc(profiles): add module level doc (rust-lang/cargo#11219) - refactor(publish): Clarify which SourceId is being used (rust-lang/cargo#11216) - Add new SourceKind::SparseRegistry to differentiate sparse registries (rust-lang/cargo#11209) - Fix deadlock when build scripts are waiting for input on stdin (rust-lang/cargo#11205) - refactor: New variant `FeaturesFor::ArtifactDep` (rust-lang/cargo#11184) - Fix rustdoc warning about unclosed HTML tag (rust-lang/cargo#11221) - refactor(tests): Prepare for wait-for-publish test changes (rust-lang/cargo#11210) - Add configuration option for controlling crates.io protocol (rust-lang/cargo#11215)

Muscraft and others added 3 commits October 13, 2022 08:40

test(registry): Allow custom_responders to call normal responders

8fadfe7

test(publish): Demonstrate the impact of non-blocking publish

66b62d2

rust-highfive assigned weihanglo Oct 13, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 13, 2022

weihanglo approved these changes Oct 13, 2022

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2022

bors merged commit b592ba4 into rust-lang:master Oct 13, 2022

bors mentioned this pull request Oct 13, 2022

Stabilize sparse-registry #11224

Merged

epage deleted the unstable2 branch October 13, 2022 17:56

weihanglo mentioned this pull request Oct 14, 2022

Update cargo rust-lang/rust#103041

Merged

weihanglo mentioned this pull request Oct 30, 2022

Tracking Issue for publish-timeout #11222

Open

2 tasks

ehuss added this to the 1.66.0 milestone Jul 13, 2023

epage mentioned this pull request Jan 2, 2025

Publishing multiple packages should not say “You may press ctrl-c to skip waiting” #15005

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(publish): Support 'publish.timeout' config behind '-Zpublish-timeout'#11230

feat(publish): Support 'publish.timeout' config behind '-Zpublish-timeout'#11230
bors merged 3 commits intorust-lang:masterfrom
epage:unstable2

epage commented Oct 13, 2022

Uh oh!

rust-highfive commented Oct 13, 2022

Uh oh!

weihanglo left a comment

Uh oh!

weihanglo commented Oct 13, 2022

Uh oh!

bors commented Oct 13, 2022

Uh oh!

bors commented Oct 13, 2022

Uh oh!

bors commented Oct 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

epage commented Oct 13, 2022

Uh oh!

rust-highfive commented Oct 13, 2022

Uh oh!

weihanglo left a comment

Choose a reason for hiding this comment

Uh oh!

weihanglo commented Oct 13, 2022

Uh oh!

bors commented Oct 13, 2022

Uh oh!

bors commented Oct 13, 2022

Uh oh!

bors commented Oct 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants