Make the rust-version error recommend cargo update --precise -p crate@ver#10891
Merged
bors merged 2 commits intorust-lang:masterfrom Aug 9, 2022
Merged
Conversation
|
r? @ehuss (rust-highfive has picked a reviewer for you, use r? to override) |
Contributor
|
Thanks! I'm concerned that this hint may be confusing for people using I wondering if maybe this hint to run It could also check |
eb4bea0 to
931bb6c
Compare
Member
Author
|
@ehuss Good point; done. |
epage
reviewed
Jul 23, 2022
ehuss
reviewed
Jul 24, 2022
b10e9ab to
0b002e4
Compare
Member
Author
|
Fixing... |
2e44a65 to
df6e2cc
Compare
…precise ...` People encountering a dependency with a newer `rust-version` requirement may not know about `cargo update --precise`, or may consider alternate approaches that may be harmful (such as pinning with a `=` dependency). Provide specific guidance in the error message. If the user is using `cargo install`, suggest `cargo install --locked` instead.
Packages in the local workspace can't get updated this way; the user just needs to point to a different source, or otherwise update the package themselves.
df6e2cc to
934e790
Compare
ehuss
reviewed
Aug 9, 2022
Contributor
|
Thanks! @bors r+ |
Contributor
Contributor
bors
added a commit
that referenced
this pull request
Aug 9, 2022
…=ehuss Make the `rust-version` error recommend `cargo update --precise -p crate@ver` People encountering a dependency with a newer `rust-version` requirement may not know about `cargo update --precise`, or may consider alternate approaches that may be harmful (such as pinning with a `=` dependency). Provide specific guidance in the error message.
Contributor
|
💔 Test failed - checks-actions |
Contributor
|
@bors retry apt network error |
Contributor
Contributor
|
☀️ Test successful - checks-actions |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 10, 2022
Update cargo 7 commits in 4fd148c47e733770c537efac5220744945d572ef..ce40690a5e4e315d3dab0aae1eae69d0252c52ac 2022-08-03 15:03:52 +0000 to 2022-08-09 22:32:17 +0000 - Make the `rust-version` error recommend `cargo update --precise -p crate@ver` (rust-lang/cargo#10891) - resolver docs: link to version requirements syntax full explanation (rust-lang/cargo#10946) - Bump os_info to 3.5.0 (rust-lang/cargo#10943) - Mark --timings=html unstable in the document (rust-lang/cargo#10941) - Mention that aliases are recursive (rust-lang/cargo#10935) - Test if reserved filenames are allowed in Windows (rust-lang/cargo#10322) - improve error message for `no such subcommand` (rust-lang/cargo#10924)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
People encountering a dependency with a newer
rust-versionrequirementmay not know about
cargo update --precise, or may consider alternateapproaches that may be harmful (such as pinning with a
=dependency).Provide specific guidance in the error message.