clarify profile used for 'cargo install --debug'#10861
Merged
bors merged 2 commits intorust-lang:masterfrom Jul 14, 2022
Merged
clarify profile used for 'cargo install --debug'#10861bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
|
r? @ehuss (rust-highfive has picked a reviewer for you, use r? to override) |
8b8af89 to
e604eb0
Compare
e604eb0 to
79164d1
Compare
Member
Author
|
FWIW I found a copy of the same string in https://github.com/rust-lang/cargo/blob/master/src/etc/_cargo . Is that generated somehow or am I supposed to also update it? |
Contributor
That is hand maintained. |
Member
Author
|
Okay, I updated it. It doesn't use the same quotes as the Rust string since I can never remember how to do shell quote escaping in a portable way, and matching exactly doesn't seem too important anyway... |
Contributor
|
Thanks! @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 14, 2022
Update cargo 7 commits in b1dd22e668af5279e13a071ad4b17435bd6bfa4c..8827baaa781b37872134c1ba692a6f0aeb37890e 2022-07-09 14:48:50 +0000 to 2022-07-14 02:56:51 +0000 - Add a test for regressions in selecting the correct workspace root (rust-lang/cargo#10862) - clarify profile used for 'cargo install --debug' (rust-lang/cargo#10861) - servers should use 404 (rust-lang/cargo#10860) - test(add): Ensure comments are preserved (rust-lang/cargo#10849) - Fix nested workspace resolution (rust-lang/cargo#10846) - Small tweaks to the future-incompat docs. (rust-lang/cargo#10856) - Fixed extra period typo (rust-lang/cargo#10847)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TIL that the profile used by
cargo buildis calleddev, notdebug. That made me wonder, is that profile also used bycargo install --debug(despite the name of the flag being--debug, not--dev)? Turns out the answer is yes, but the first 2 places where I looked for help did not say that. So this PR changes those two places to be explicit about this.