Emit warning upon encountering multiple packages with the same name#10701
Merged
bors merged 1 commit intorust-lang:masterfrom May 31, 2022
danilhendrasr:master
Merged
Emit warning upon encountering multiple packages with the same name#10701bors merged 1 commit intorust-lang:masterfrom danilhendrasr:master
bors merged 1 commit intorust-lang:masterfrom
danilhendrasr:master
Conversation
|
r? @ehuss (rust-highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
|
Seems like the tests failed, I'll get back to it. |
Muscraft
reviewed
May 27, 2022
weihanglo
reviewed
May 28, 2022
Member
weihanglo
left a comment
There was a problem hiding this comment.
Thanks!
Could you squash git commits?
Contributor
Author
|
By squashing git commits, do you mean by doing this? |
Member
Contributor
Author
|
Done, have I done it right though? Cause I'm not familiar with this kind of situation haha. |
weihanglo
approved these changes
May 31, 2022
Member
weihanglo
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
I assume that this warning won't be too noisy in practice. If it turns out screaming too much or anyone in the cargo team disagrees, we can revert it at anytime.
Member
|
@bors r+ |
Contributor
|
📌 Commit e903f7d has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 1, 2022
Update cargo 5 commits in 39ad1039d9e3e1746177bf5d134af4c164f95528..38472bc19f2f76e245eba54a6e97ee6821b3c1db 2022-05-25 00:50:02 +0000 to 2022-05-31 02:03:24 +0000 - Emit warning upon encountering multiple packages with the same name (rust-lang/cargo#10701) - Guide new users to add use `super::*;` to `mod test` (rust-lang/cargo#10706) - Document how to debug change detection events (rust-lang/cargo#10708) - fix(publish): add more check when use `publish -p <SPEC>` (rust-lang/cargo#10677) - fix key formatting when switching to a dotted `WorkspaceSource` (rust-lang/cargo#10705)
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #10669