Skip to content

Remove "pub" specifier from function eat_at_restaurant#1895

Closed
liufeimath wants to merge 1 commit intorust-lang:masterfrom
liufeimath:remove_pub
Closed

Remove "pub" specifier from function eat_at_restaurant#1895
liufeimath wants to merge 1 commit intorust-lang:masterfrom
liufeimath:remove_pub

Conversation

@liufeimath
Copy link

@liufeimath liufeimath commented Apr 7, 2019

I'm removing "pub" specifier from function eat_at_restaurant for two reasons:

  1. The first time this "pub" appears (Ch 7.3, or source code ch07-03-paths-for-referring-to-an-item-in-the-module-tree.md, line 34), we haven't introduced the keyword "pub" yet. It creates confusions.
  2. The "pub" specifier for eat_at_restaurant is not useful or relevant to the whole chapter.

@carols10cents carols10cents added this to the ch7 milestone Apr 12, 2019
carols10cents added a commit that referenced this pull request Apr 12, 2019
@carols10cents
Explain why eat_at_restaurant is pub
047fe34 
Fixes the problem fixed in #1895
@carols10cents
Copy link
Member

carols10cents commented Apr 12, 2019

Thanks! I've opted to fix this by adding a quick note about what the pub does; you're right that it's not directly relevant to the examples but my intent was to make this as real an example as possible and show a public API function. For the examples that compile, if the pub isn't there, you get an unused code warning, which could be equally confusing.

Lodewijikb added a commit to Lodewijikb/http-api-docs that referenced this pull request Nov 25, 2025
@Lodewijikb
fixes the problem fixed in rust-lang/book#1895
e19025b
ksasar1000 added a commit to ksasar1000/react-native-app-intro that referenced this pull request Nov 25, 2025
@ksasar1000
fixes the problem fixed in rust-lang/book#1895
c25e30b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

ch7

Development

Successfully merging this pull request may close these issues.

2 participants

@liufeimath @carols10cents