[AIX] Update backtrace to account for libc changes and fix XCOFF parsing#757
Merged
workingjubilee merged 2 commits intoJun 11, 2026
Merged
Conversation
This patch synchronizes AIX backtrace support with newer libc updates and fix type correctness issues: - Bump libc to 0.2.175 to pick up latest AIX-related fixes. - Update libc::loadquery buffer argument to use *mut c_void instead of *mut c_char, matching the current libc API. - Fix XCOFF section name comparison to handle Option<&[u8]>.
Member
|
Thanks! Will try to take a look soon. |
Member
|
rustfmt failure |
Contributor
Author
|
Ah, I missed that. Thanks a lot! Just fixed them. |
Member
|
Yay, can merge this then. |
| if libc::loadquery( | ||
| libc::L_GETINFO, | ||
| buffer.as_mut_ptr().cast::<libc::c_char>(), | ||
| buffer.as_mut_ptr().cast::<libc::c_void>(), |
Member
There was a problem hiding this comment.
though is there a reason this isn't core::ffi::c_void?
should be fine either way I s'pose.
Contributor
Author
There was a problem hiding this comment.
Oops, good point. Honestly, no strong reason, I used libc::c_void since it matched the loadquery() signature.
Member
There was a problem hiding this comment.
That should just be a reexport from core so hopefully it doesn't matter (it's just nice to reduce indirection when viable).
workingjubilee
approved these changes
Jun 10, 2026
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 21, 2026
…, r=Mark-Simulacrum Update backtrace submodule to pick up AIX related fixes. This change updates the backtrace submodule, primarily to pick up the AIX related fixes from rust-lang/backtrace-rs#757.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 21, 2026
…, r=Mark-Simulacrum Update backtrace submodule to pick up AIX related fixes. This change updates the backtrace submodule, primarily to pick up the AIX related fixes from rust-lang/backtrace-rs#757.
rust-timer
added a commit
to rust-lang/rust
that referenced
this pull request
Jun 22, 2026
Rollup merge of #158150 - amy-kwan:amy-kwan/Update-backtrace, r=Mark-Simulacrum Update backtrace submodule to pick up AIX related fixes. This change updates the backtrace submodule, primarily to pick up the AIX related fixes from rust-lang/backtrace-rs#757.
pull Bot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Jun 22, 2026
…Simulacrum Update backtrace submodule to pick up AIX related fixes. This change updates the backtrace submodule, primarily to pick up the AIX related fixes from rust-lang/backtrace-rs#757.
pull Bot
pushed a commit
to p-avital/rust-analyzer
that referenced
this pull request
Jun 22, 2026
…Simulacrum Update backtrace submodule to pick up AIX related fixes. This change updates the backtrace submodule, primarily to pick up the AIX related fixes from rust-lang/backtrace-rs#757.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch synchronizes AIX backtrace support with newer libc updates and fix type correctness issues: