Merged
Conversation
This was referenced Nov 21, 2017
Member
Author
|
Regarding names, how about |
Member
Author
I'm going ahead with
I'm going to defer this until right before the actual release @homunkulus r+ |
Contributor
|
📌 Commit e114878 has been approved by |
Contributor
japaric
pushed a commit
that referenced
this pull request
Dec 9, 2017
Peripherals as scoped singletons See this RFC for details: #157 With this change device crates will need to depend on a version of the cortex-m crate that includes rust-embedded/cortex-m#65 ### TODO - [x] accept the RFC - [ ] Check that non cortex-m targets still work - [x] decide on better names for `Peripherals::{all,_all}`
Member
Author
|
@homunkulus r+ |
Contributor
|
📌 Commit 56cd979 has been approved by |
Contributor
japaric
pushed a commit
that referenced
this pull request
Dec 9, 2017
Peripherals as scoped singletons See this RFC for details: #157 With this change device crates will need to depend on a version of the cortex-m crate that includes rust-embedded/cortex-m#65 ### TODO - [x] accept the RFC - [ ] Check that non cortex-m targets still work - [x] decide on better names for `Peripherals::{all,_all}`
Contributor
|
💔 Test failed - status-travis |
Member
Author
|
@homunkulus r+ |
Contributor
|
📌 Commit 9c2ec7b has been approved by |
Contributor
japaric
pushed a commit
that referenced
this pull request
Dec 9, 2017
Peripherals as scoped singletons See this RFC for details: #157 With this change device crates will need to depend on a version of the cortex-m crate that includes rust-embedded/cortex-m#65 ### TODO - [x] accept the RFC - [ ] Check that non cortex-m targets still work - [x] decide on better names for `Peripherals::{all,_all}`
japaric
pushed a commit
to rtic-rs/rtic
that referenced
this pull request
Dec 9, 2017
Peripherals as scoped singletons See this RFC for details: rust-embedded/svd2rust#157 - The first commit adapts this crate to the changes in rust-embedded/cortex-m#65 and rust-embedded/svd2rust#158 - ~~The second commit is an alternative implementation of RFC #47 (there's another implementation in #49. This second commit is not required for RFC157 but let us experiment with safe DMA abstractions.~~ postponed ### TODO - [x] un-bless peripherals as resources. Peripherals as resources were special cased: if resource listed in e.g. `app.tasks.FOO.resources` didn't appear in `app.resources` then it was assumed to be a peripheral and special code was generated for it. This is no longer required under RFC157. ~~This depends on PR rtic-rs/rtic-syntax#2~~ postponed
Member
Author
|
@homunkulus r+ |
Contributor
|
📌 Commit 3b27815 has been approved by |
Contributor
japaric
pushed a commit
that referenced
this pull request
Dec 9, 2017
Peripherals as scoped singletons See this RFC for details: #157 With this change device crates will need to depend on a version of the cortex-m crate that includes rust-embedded/cortex-m#65 ### TODO - [x] accept the RFC - [ ] Check that non cortex-m targets still work - [x] decide on better names for `Peripherals::{all,_all}`
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
Member
I like those! Short and to the point! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See this RFC for details: #157
With this change device crates will need to depend on a version of the cortex-m crate that includes rust-embedded/cortex-m#65
TODO
Check that non cortex-m targets still workpostponedPeripherals::{all,_all}