This repository was archived by the owner on Jan 24, 2022. It is now read-only.
Allow using the crate with custom target JSON specs#304
Merged
bors[bot] merged 1 commit intorust-embedded:masterfrom Jan 8, 2021
jonas-schievink:target-json
Merged
Allow using the crate with custom target JSON specs#304bors[bot] merged 1 commit intorust-embedded:masterfrom jonas-schievink:target-json
bors[bot] merged 1 commit intorust-embedded:masterfrom
jonas-schievink:target-json
Conversation
|
r? @adamgreig (rust-highfive has picked a reviewer for you, use r? to override) |
Member
|
Idea seems good but this breaks when target is |
Contributor
Author
|
|
Member
|
Won't it also run for just "--target thumbv8m.base-none-eabi", without a JSON spec, though? |
Contributor
Author
|
Oh, right, that's a problem. |
bors bot
added a commit
that referenced
this pull request
Jan 8, 2021
304: Allow using the crate with custom target JSON specs r=adamgreig a=jonas-schievink This should fix #145 (cc @thejpster) Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Contributor
|
Build failed: |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #145 (cc @thejpster)