Conversation
|
r? @therealprof (rust_highfive has picked a reviewer for you, use r? to override) |
jonas-schievink
left a comment
There was a problem hiding this comment.
CriticalSectionMutex is not Sync, so it doesn't really work as a mutex like this
|
Hey @korken89, I'm not sure it's possible to share this mutex between an interrupt and main with this, at least without using Additionally, it's kind of a bummer that this mutex panics if the resource is taken, but I guess that was already decided based on the Mutex-Trait API. |
|
Right, I have to move to |
Co-Authored-By: Jonas Schievink <jonasschievink@gmail.com>
|
What happens now if I lock the mutex while already holding it? |
|
Ah right, now I remember the original issue around the implementation - thanks for pointing it out. |
|
Discussion from the meeting: Seems this has stalled out. Maybe this could be another focus project? If people are interested in joining such a group, please speak up. The MSP430 team is considering taking over the current implementation from bare-metal to not keep unneeded dependencies around. |
|
I'm triaging Cortex-M issues, I think this has been solved with critical-section. Feel free to re-open if there's still something to discus here! |
I started the implementation for an arch specific mutex to get discussion going.