Add basic derives for Parity#361
Merged
apoelstra merged 3 commits intorust-bitcoin:masterfrom Jan 6, 2022
Merged
Conversation
Member
Author
|
Another patch. This should be the last one. I have tested this downstream with rust-bitcoin @apoelstra |
89b70c0 to
82c2169
Compare
Member
Author
|
I initially tried to do auto-derives for serde, but I was facing a lot of issues because of MSRV. It required me to do pinning for underlying dependencies for 1.29. I have implemented a custom Visitor for Parity by basically pasting code. |
82c2169 to
1671dfc
Compare
apoelstra
reviewed
Jan 6, 2022
| mod serde_util; | ||
|
|
||
| pub use key::{SecretKey, PublicKey, ONE_KEY, KeyPair, XOnlyPublicKey, Parity}; | ||
| pub use key::*; |
Member
There was a problem hiding this comment.
Actually @TheBlueMatt pointed out to me that there's no way it could, since the top-level module doesn't have visibility into things in key that aren't pub.
Member
Author
There was a problem hiding this comment.
Nope. If something is not defined pub, it won't be exported. We doing something similar to context.
apoelstra
approved these changes
Jan 6, 2022
Member
|
Thanks for scrambling to fix this all this @sanket1729 |
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
1671dfc2ed7f35fc71ee256392a34196b081744d Release 0.21.2 (sanket1729) 837be22e09b9e1a51eea26a67ec4112fcdf83d6e Basic derives for Parity (sanket1729) 7059192de9e1fb6cf24cb03e8be31a4d6b4f6587 Wildcard export from key module (sanket1729) Pull request description: Sorry for getting another point release. This time I have tested against this branch for rust-bitcoin rust-bitcoin/rust-bitcoin#755. Hopefully, this is the last release. Next release, we should have a Release Candidate for a couple of days before publishing a release. ACKs for top commit: apoelstra: ACK 1671dfc2ed7f35fc71ee256392a34196b081744d Tree-SHA512: 263ad027da3da764bd76f719200382c47ba21a976caefc23ebef45d1c4be35ddfc80ce619b57326310aaab22bbf75ca7f1db80b45e95ec076584805efb791f3f
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
1671dfc2ed7f35fc71ee256392a34196b081744d Release 0.21.2 (sanket1729) 837be22e09b9e1a51eea26a67ec4112fcdf83d6e Basic derives for Parity (sanket1729) 7059192de9e1fb6cf24cb03e8be31a4d6b4f6587 Wildcard export from key module (sanket1729) Pull request description: Sorry for getting another point release. This time I have tested against this branch for rust-bitcoin rust-bitcoin/rust-bitcoin#755. Hopefully, this is the last release. Next release, we should have a Release Candidate for a couple of days before publishing a release. ACKs for top commit: apoelstra: ACK 1671dfc2ed7f35fc71ee256392a34196b081744d Tree-SHA512: 263ad027da3da764bd76f719200382c47ba21a976caefc23ebef45d1c4be35ddfc80ce619b57326310aaab22bbf75ca7f1db80b45e95ec076584805efb791f3f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for getting another point release. This time I have tested against this branch for rust-bitcoin rust-bitcoin/rust-bitcoin#755. Hopefully, this is the last release.
Next release, we should have a Release Candidate for a couple of days before publishing a release.