Merged
Conversation
Add a `just` config file with various useful commands. Note that a bunch of these commands do not succeed currently on master, specifically: - just lint - just docsrs - just sane Will fix as separate PRs
Member
Author
apoelstra
approved these changes
Mar 28, 2024
apoelstra
added a commit
that referenced
this pull request
Mar 29, 2024
7634642 Use struct update syntax (Tobin C. Harding) 2bc083e Use iterator instead of manual loop (Tobin C. Harding) 6d663e1 Allow range loop in test code (Tobin C. Harding) a8c156e Use map instead of and_then (Tobin C. Harding) d5662da Remove redundant closure (Tobin C. Harding) 90f1585 Remove redundant clone (Tobin C. Harding) 409d4b0 Remove explicit reference (Tobin C. Harding) 9ec6b17 Remove redundant field names in struct initialization (Tobin C. Harding) Pull request description: After doing #668 I wanted to be able to use the `just sane` command before pushing PRs, so fix the lint issues. ACKs for top commit: apoelstra: ACK 7634642 thanks! we should re-enabled Clippy in CI in this repo...I believe we disabled it due to a clippy bug in July Tree-SHA512: 1e953f2fc1a6e649324293a84abf1be54feca6095111653af046aacf17a83e6ae15452fe8825599ccbfae0ea84fe7d1988c8b72d5dd902c9d0fb1d34e660ef8b
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
9f5849f64cebe8d0a5756d3007fdfe6d2676185f Add justfile (Tobin C. Harding)
Pull request description:
Add a `just` config file with various useful commands. Note that a bunch of these commands do not succeed currently on master, specifically:
- just lint
- just docsrs
- just sane
Will fix as separate PRs
ACKs for top commit:
apoelstra:
ACK 9f5849f64cebe8d0a5756d3007fdfe6d2676185f
Tree-SHA512: 59e7c0feb72e43f3b3e9e89d1d6549f57c7fa7ca1cd48eb845ef90ddec7374c2478380c5763a041849c5113153139fb90e2b2865a1c72532aadd618d24449816
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
justconfig file with various useful commands. Note that a bunch of these commands do not succeed currently on master, specifically:Will fix as separate PRs