Fix a bunch of clippy lints#627
Merged
apoelstra merged 8 commits intorust-bitcoin:masterfrom Nov 7, 2023
Merged
Conversation
Member
|
Ha! linting like your a junior dev, thanks bro ... we need some junior devs around here. |
5a131ce to
fd1b352
Compare
Member
Author
|
CI is failing because of rust-lang/rust-clippy#11752. Will need to whitelist this lint. |
tcharding
approved these changes
Nov 3, 2023
Member
|
If you were a junior dev I'd make you iterate on this one. Perhaps squash the whole thing into a single commit, you don't want all those commits in the index for ever :) (I'm still chuckling, the changes are all mixed up, random stuff in |
Member
|
The CI fail is legit, just got an unused import in there. |
Also fixes a bunch of unused imports that are detected by the latest rustc nightly. (One is a wildcard import that actually imports nothing; the other are prelude things in a private prelude module.)
89dd79e to
1d70468
Compare
1d70468 to
7eccfdb
Compare
tcharding
approved these changes
Nov 3, 2023
Member
Author
|
cc @sanket1729 I think we need your ACK here. |
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
7eccfdbee63bb3e97dd441fe0135e639667a829c clippy: whitelist iter_kv lint since it is broken (Andrew Poelstra)
6de288f1d03369ee9d8f86dcd740a02b7ecdb52a cargo fmt (Andrew Poelstra)
f9c4e533af2b0b3c3b07af6f632b9781eb04ae7f clippy: fix PartialOrd impl on an Ord type (Andrew Poelstra)
1f8dfe26211255a4ae53a00e60007af3d1d8d166 clippy: clean up iterator (Andrew Poelstra)
5ab7afefd32ce0edc585d81f3d15226829cb1f50 clippy: whitelist inapplicable lints (Andrew Poelstra)
223790623d0a01f3a991347920f0cb7417f957e8 clippy: use try_fold in place of fold in several places (Andrew Poelstra)
4f7782f9f8e14da99714b3b9c85b4820a74bd794 clippy: minor things (Andrew Poelstra)
a61f71a537e8920cf1a53e594617c3e318d1c41b clippy: eliminate a bunch of redundant `into_iter` calls (Andrew Poelstra)
Pull request description:
Supercedes #615.
ACKs for top commit:
tcharding:
ACK 7eccfdbee63bb3e97dd441fe0135e639667a829c
sanket1729:
ACK 7eccfdbee63bb3e97dd441fe0135e639667a829c
Tree-SHA512: ea4f14f754b07c9ae127684e6ca1d9f121361a7be617d45a19af0269af735d2f420f59abdf15b943052b34cc9afba31cddc87d75a86694f8eefa0d672d4b031b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supercedes #615.