Fixing the Inclusivity of Z in StrKeyTranslator#523
Merged
apoelstra merged 2 commits intorust-bitcoin:masterfrom Feb 3, 2023
Merged
Fixing the Inclusivity of Z in StrKeyTranslator#523apoelstra merged 2 commits intorust-bitcoin:masterfrom
apoelstra merged 2 commits intorust-bitcoin:masterfrom
Conversation
Signed-off-by: Harshil Jani <harshiljani2002@gmail.com>
Member
|
Oof, looks like some sort of Github hiccup is causing CI failures. Will retry in a few hours. |
apoelstra
previously approved these changes
Feb 1, 2023
Contributor
Author
|
Opened an issue for this at |
Member
|
@Harshil-Jani if you look at our existing Or we'll get to it in some other PR, but yours happens to be active :) |
Signed-off-by: Harshil Jani <harshiljani2002@gmail.com>
apoelstra
approved these changes
Feb 3, 2023
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
…n StrKeyTranslator
76fb99c5e89daa0b768c3b66b82b4b13977a6061 Fix the CI failing due to `which` crate (Harshil Jani)
ebe3245cbca3969d8cd2e294f1fd043a98542b6f Fixing the Inclusivity of Z in StrKeyTranslator (Harshil Jani)
Pull request description:
Fixing `StrKeyTranslator` in `test_utils.rs` where Z was not included.
Closes #496
Signed-off-by: Harshil Jani <harshiljani2002@gmail.com>
ACKs for top commit:
apoelstra:
ACK 76fb99c5e89daa0b768c3b66b82b4b13977a6061
Tree-SHA512: 91f73014338c8943ab59bfc4c9e16de44ac6d752f2ce7cb3a84413fbf17bf47d17351ed20707b45ce9c554341a43d0b2faa4ab856d3e734275f5dfd626f4f515
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing
StrKeyTranslatorintest_utils.rswhere Z was not included.Closes #496
Signed-off-by: Harshil Jani harshiljani2002@gmail.com