Merged
Conversation
Earlier, we only implemented `expr_raw_pkh` which was used as shortcut for c:expr_raw_pk_h. Note the inclusion of additional _
psbts where we needed to dissatisfy pkh did not work properly as we did not implement the mapping pkh->pk required for dissatisfaction of pkh fragment. We now look for this mapping in bip32 derivation field of psbt. Our update_utxo_from_descriptor API correctly procesess these fields.
Same example as posted in discussions
262049b to
7e1a7a0
Compare
Member
|
I'm not sure that we can change the |
Member
|
Changing the signature of |
Member
|
All changes in 7e1a7a0 look good to me, but they're all API-breaking and I think we need to release 9.0.0 with them. |
Member
Author
|
All of the changes are related to the raw APIs. I was thinking we can just
justify them as a bug fix instead of major release?
Thinking from a software sense, it makes sense to call it a breaking
change.
…On Mon, Nov 7, 2022, 2:03 PM Andrew Poelstra ***@***.***> wrote:
All changes in 7e1a7a0
<7e1a7a0>
look good to me, but they're all API-breaking and I think we need to
release 9.0.0 with them.
—
Reply to this email directly, view it on GitHub
<#488 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABUQEOIJFIAKIEGDXKS7RELWHF4E3ANCNFSM6AAAAAARX3MG4E>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@apoelstra what is expected date for the next release if the fix goes with it? |
Member
Author
|
@engenegr, you can expect a new release early next week. |
7e1a7a0 to
01a2b97
Compare
Member
Author
|
Changed to release 9.0.0 |
Member
|
@sanket1729 you did not change the actual commit to 9.0.0! |
Member
Author
|
@apoelstra , lol. Good catch. I think you mean Cargo.toml file? |
01a2b97 to
a113e35
Compare
apoelstra
approved these changes
Nov 14, 2022
Member
|
Tagged & published |
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
a113e35923dc094b2554209d2042ac8d7683ebb7 Release 9.0.0 (sanket1729)
63ceb5b38d641c543f01f955728627ea2a89444a Add psbt example for sign and finalize (sanket1729)
8f869926714c5c7273b217bd3f72d5cab26d6560 Don't run rawpkh logic through pkh (sanket1729)
815fd1c9b368f800bb67d1ecdd49c533394d4b8c Bug fix: pkh->pk lookup API (sanket1729)
43abc43bb0b83ca9da61f80ed3cc848e4e34d762 Use expr_raw_pk_h for Terminal::RawPkH (sanket1729)
Pull request description:
- Cleanup some pkh code in satisfaction
- Fixes #483
- Fixes another bug dealing with dissatisfaction of thresh inside pkh
- Adds example test vector from discussions
- release 9.0.0 with above fixes
ACKs for top commit:
apoelstra:
ACK a113e35923dc094b2554209d2042ac8d7683ebb7
Tree-SHA512: 373d80c5bc03032635ce0dfe6426b17970f1590012482ad3cc76b37337fe2f53e51b32e1fe11c449ec38bf4d4a0ba62d38f7316a148773e2b1854b8f9f1a877c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.