Rectify from_multi_a max satisfaction size#346
Merged
sanket1729 merged 1 commit intorust-bitcoin:masterfrom Apr 27, 2022
Merged
Rectify from_multi_a max satisfaction size#346sanket1729 merged 1 commit intorust-bitcoin:masterfrom
from_multi_a max satisfaction size#346sanket1729 merged 1 commit intorust-bitcoin:masterfrom
Conversation
Cost incurred for a single Schnorr signature in the witness stack := `<var_int><64-byte signature><sig_type>` = 1 + 64 + 1
Member
|
This is a minor bug, that can go in a point release. Will affect fee cost estimation by 2 bytes per pubkey in multi_a. |
Member
|
This breaks the CI tests, because it is based on 0.28.0-rc.2 . Now that we have 0.28.0 cargo automatically fetches it and causes other misc errors on the merge commit. |
Member
|
Fix would be to re-open tihs after we get 7.0.0 release and rebase on top on that |
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
…tisfaction size 747876ed7104738e89de5d7574e66db66adc30e9 Rectify `from_multi_a` max satisfaction size (Aman Rojjha) Pull request description: Cost incurred for a single Schnorr signature in the witness stack := `<var_int><64-byte signature><sig_type>` = 1 + 64 + 1 (as clarified by @sanket1729 in #340 ). ACKs for top commit: sanket1729: ACK 747876ed7104738e89de5d7574e66db66adc30e9 Tree-SHA512: f20652240f1daa7b33b1d525870114e0bd6412e82845e80a94c616dedcfb3d8ae2f7ef19d7c08760f79270e0d465c18b713eff2e3e599b45c65f2a64da36713b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cost incurred for a single Schnorr signature in the witness stack :=
<var_int><64-byte signature><sig_type>= 1 + 64 + 1 (as clarified by @sanket1729 in #340 ).